Skip to content

Commit e2e97b4

Browse files
authored
fix: Disable cross-frame focus lock (#840)
1 parent e194265 commit e2e97b4

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.
44

5+
# v25.1.1
6+
7+
- [Fix] Restrict focus locking in the `Modal` component to its containing document/iframe.
8+
59
# v25.1.0
610

711
- [Feat] Add `xsmall` size to the `Modal` component

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"email": "henning@doist.com",
77
"url": "http://doist.com"
88
},
9-
"version": "25.1.0",
9+
"version": "25.1.1",
1010
"license": "MIT",
1111
"homepage": "https://github.com/Doist/reactist#readme",
1212
"repository": {

src/modal/modal.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,12 @@ export function Modal({
247247
onPointerDown={hideOnInteractOutside ? handleBackdropClick : undefined}
248248
ref={backdropRef}
249249
>
250-
<FocusLock autoFocus={autoFocus} whiteList={isNotInternalFrame} returnFocus={true}>
250+
<FocusLock
251+
autoFocus={autoFocus}
252+
whiteList={isNotInternalFrame}
253+
returnFocus={true}
254+
crossFrame={false}
255+
>
251256
<Dialog
252257
{...props}
253258
ref={dialogRef}

0 commit comments

Comments
 (0)