Skip to content

Commit f269e67

Browse files
authored
fix: Explicitly omit crossOrigin and placeholder props (#812)
1 parent 535d69c commit f269e67

File tree

10 files changed

+16
-8
lines changed

10 files changed

+16
-8
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.
44

5+
# v23.0.0
6+
7+
- [BREAKING] Remove unsupported `crossOrigin` attribute from `input`- and `textarea`-based components.
8+
- [BREAKING] Remove unsupported `placeholder` attribute from heading components.
9+
510
# v22.3.3
611

712
- [Fix] Vertical alignment of inline code elements inside a `Prose` component

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"email": "henning@doist.com",
77
"url": "http://doist.com"
88
},
9-
"version": "22.3.3",
9+
"version": "23.0.0",
1010
"license": "MIT",
1111
"homepage": "https://github.com/Doist/reactist#readme",
1212
"repository": {

src/checkbox-field/checkbox-field.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ type CheckboxFieldProps = Omit<
1515
| 'aria-describedby'
1616
| 'aria-label'
1717
| 'aria-labelledby'
18+
| 'crossOrigin'
1819
> & {
1920
'aria-checked'?: never
2021
/** Identifies the set of checkboxes controlled by the mixed checkbox for assistive technologies. */

src/heading/heading.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type HeadingElement = 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6'
1111

1212
type SupportedHeadingElementProps = Omit<
1313
JSX.IntrinsicElements[HeadingElement],
14-
'className' | 'children'
14+
'className' | 'children' | 'placeholder'
1515
>
1616

1717
type HeadingProps = SupportedHeadingElementProps & {

src/password-field/password-field.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { Button } from '../button'
88

99
import type { BaseFieldVariantProps } from '../base-field'
1010

11-
type PasswordFieldProps = Omit<TextFieldProps, 'type' | 'startSlot' | 'endSlot'> &
11+
type PasswordFieldProps = Omit<TextFieldProps, 'type' | 'startSlot' | 'endSlot' | 'crossOrigin'> &
1212
BaseFieldVariantProps & {
1313
togglePasswordLabel?: string
1414
}

src/select-field/select-field.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ import { BaseField, BaseFieldVariantProps, FieldComponentProps } from '../base-f
33
import { Box } from '../box'
44
import styles from './select-field.module.css'
55

6-
type SelectFieldProps = FieldComponentProps<HTMLSelectElement> & BaseFieldVariantProps
6+
type SelectFieldProps = Omit<FieldComponentProps<HTMLSelectElement>, 'crossOrigin'> &
7+
BaseFieldVariantProps
78

89
const SelectField = React.forwardRef<HTMLSelectElement, SelectFieldProps>(function SelectField(
910
{

src/switch-field/switch-field.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ type SwitchFieldProps = Omit<
1616
| 'aria-describedby'
1717
| 'aria-label'
1818
| 'aria-labelledby'
19+
| 'crossOrigin'
1920
> & {
2021
/** Identifies the element (or elements) that describes the switch for assistive technologies. */
2122
'aria-describedby'?: string

src/text-area/text-area.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { BaseField, BaseFieldVariantProps, FieldComponentProps } from '../base-f
44
import { Box } from '../box'
55
import styles from './text-area.module.css'
66

7-
type TextAreaProps = FieldComponentProps<HTMLTextAreaElement> &
7+
type TextAreaProps = Omit<FieldComponentProps<HTMLTextAreaElement>, 'crossOrigin'> &
88
BaseFieldVariantProps & {
99
/**
1010
* The number of visible text lines for the text area.

src/text-field/text-field.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { useMergeRefs } from 'use-callback-ref'
77

88
type TextFieldType = 'email' | 'search' | 'tel' | 'text' | 'url'
99

10-
type TextFieldProps = Omit<FieldComponentProps<HTMLInputElement>, 'type'> &
10+
type TextFieldProps = Omit<FieldComponentProps<HTMLInputElement>, 'type' | 'crossOrigin'> &
1111
BaseFieldVariantProps & {
1212
type?: TextFieldType
1313
startSlot?: React.ReactChild

0 commit comments

Comments
 (0)