Remove uses of utcnow, update deps for python 3.12 #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-doist
commented
Feb 27, 2025
| not_found_entries = [] | ||
|
|
||
| now = datetime.datetime.utcnow() | ||
| now = datetime.now(tz=timezone.utc) |
There was a problem hiding this comment.
Note -- we're using datetime.timezone.utc in all these places instead of datetime.UTC like we do in Todoist; they are the same thing, but the datetime.UTC alias was only created in python 3.11, and for this library we want to maintain compatibility farther back than that 👍
proxi
approved these changes
Feb 28, 2025
goncalossilva
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
PR Overview
This PR updates the project to use timezone-aware datetimes instead of naive ones and bumps dependency versions to support Python 3.12.
- Updated tests (conftest.py) to generate queue names with aware datetimes.
- Replaced all naive datetime usages with timezone-aware alternatives in the SQS in-memory implementation and shutdown policies.
- Updated pre-commit configuration to use Python 3.12.
Reviewed Changes
| File | Description |
|---|---|
| tests/conftest.py | Uses aware datetime for constructing test SQS queue prefixes. |
| sqs_workers/memory_sqs.py | Updated datetime usages to be timezone aware in SQS in-memory logic. |
| sqs_workers/shutdown_policies.py | Replaced naive datetime with aware datetime in shutdown logic. |
| .pre-commit-config.yaml | Updated Python version from 3.11 to 3.12 in pre-commit configuration. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the title says! Switches from naive datetimes to aware ones, which from my looking at the places they're used, I don't think will cause any problems --
memory_sqsis only used for tests, and shutdown policy's_last_seenis maintained totally by us (e.g. we're not comparing datetimes to responses from AWS).(but please double-check this ^ with me)!
Also updates the versions of dependencies in
poetry.lock.