Migrate from attrs to dataclasses #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncalossilva
commented
Apr 14, 2025
| else: | ||
| kwargs = bind_arguments(self.processor, args, kwargs) | ||
| return self.processor(**kwargs) | ||
| return self.processor(**kwargs) # type:ignore[call-arg] |
There was a problem hiding this comment.
I had to add this ignore even before making any changes. Running mypy failed with:
sqs_workers/async_task.py:65: error: Too few arguments [call-arg]
sqs_workers/async_task.py:68: error: Too few arguments [call-arg]
Found 2 errors in 1 file (checked 25 source files)
I did spent a couple of minutes trying to grasp the problem, but I couldn't. I'm not familiar with this codebase, so it may be more obvious to you. But if not, we can keep this for the time being. :)
There was a problem hiding this comment.
(same on line 65, it's the same problem)
goncalossilva
force-pushed
the
goncalossilva/migrate-to-dataclasses
branch
2 times, most recently
from
d3478dc to
7d82091
Compare
goncalossilva
force-pushed
the
goncalossilva/migrate-to-dataclasses
branch
from
7d82091 to
89983bd
Compare
proxi
reviewed
Apr 15, 2025
proxi
approved these changes
Apr 15, 2025
|
We have reasonable test coverage. :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates from attrs to dataclasses. Claude did most of the heavy lifting, with my supervision. :)
Beyond tests (
memoryandlocalstack), I leveraged ruff and mypy liberally for this.