Skip to content

[Feature Request]: Integrate Clusters into the DoubleMLData Class #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SvenKlaassen opened this issue Apr 3, 2025 · 1 comment
Open
Labels
enhancement extension of existing feature new feature new feature

Comments

@SvenKlaassen
Copy link
Member

Describe the feature you want to propose or implement

Clusters should be element of the basic DoubleMLData class.

Propose a possible solution or implementation

No response

Did you consider alternatives to the proposed solution. If yes, please describe

No response

Comments, context or references

No response

@SvenKlaassen SvenKlaassen added enhancement extension of existing feature new feature new feature labels Apr 3, 2025
@SvenKlaassen SvenKlaassen added this to the Release 0.11.0 milestone Apr 3, 2025
@JanTeichertKluge
Copy link
Member

  • Create custom data backend/classes for model-submodules.
    • The base data backend should include $Y$, $D$, $X$ and instruments $Z$.
    • Then, e.g. t is only added to the DID data Backend, s only for sample-selection models, etc.
  • n-obs needed for variance estimation (for panel data, n_ids = total observations, scaled by sqrt n * t). May need different n_obs for different asymptotics.
  • If the Base Data class has implemented the cluster options, how should the workflow, whether ClusterData or not, be handled? By flag indicators or by dynamic properties of the dataframe (cluster_id = None or similar?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement extension of existing feature new feature new feature
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants
@SvenKlaassen @JanTeichertKluge and others