LPLR model #365

jer2ig · 2025-10-27T21:16:39Z

Addition of logistic partially linear model.

Created PR to check for merging and review changes. Unit tests in work.

Added test set-up

doubleml/datasets.py

doubleml/double_ml_data.py

doubleml/plm/datasets/dgp_lplr_LZZ2020.py

doubleml/plm/lplr.py

doubleml/plm/tests/_utils_logistic_manual.py

doubleml/plm/tests/test_lplr_exceptions.py

doubleml/plm/tests/tests_logistic.py

doubleml/plm/lplr.py

doubleml/plm/tests/_utils_lplr_manual.py

doubleml/plm/tests/test_lplr.py

JanTeichertKluge · 2025-10-28T10:18:06Z

doubleml/plm/lplr.py

+
+        return self
+
+    def set_sample_splitting(self):


Please refer to the change in PR #338 , specifically the new mixin. This replaces the class-specific implementation of all sample-splitting methods. I would recommend adapting this to the current main version and using the mixins.

doubleml/plm/tests/test_lplr_tune.py

jer2ig added 14 commits October 24, 2025 13:47

Logistic regression implementation WIP

df03887

First WIP of implementation

f5521f1

Working implementation. Started on test set-up.

bfa756c

Changed data type of arrays

d729d0a

Fix variable name

8fe7ca6

Moved into plm folder, started testing setup

18bac23

Fixed bug in score computation

c6e600d

Reverted from ensure_all_finite to force_all_finite

6f556e0

Fixes to instrument score

3a332bf

Added option for exception on convergence failure

b41a773

Added unbalanced dataset option, bug fixes

c434667

Added binary treatment dataset, fixed bug for model check

443d82d

Adjusted dataset balancing

774c74d

Renamed Logistic to LPLR

9695820

Added test set-up

github-advanced-security bot found potential problems Oct 27, 2025

View reviewed changes

jer2ig added 2 commits October 27, 2025 14:19

Clean-up of branch

dbfea73

Ruff checks and formatting

29114ce

github-advanced-security bot found potential problems Oct 27, 2025

View reviewed changes

doubleml/plm/lplr.py Fixed Show fixed Hide fixed

Unit tests work and bug fix in lplr

5d2d1ed

github-advanced-security bot found potential problems Oct 28, 2025

View reviewed changes

Cleanup

2c626a0

JanTeichertKluge reviewed Oct 28, 2025

View reviewed changes

Tests updated

9819436

github-advanced-security bot found potential problems Nov 6, 2025

View reviewed changes

doubleml/plm/tests/test_lplr_tune.py Fixed Show fixed Hide fixed

doubleml/plm/tests/test_lplr_tune.py Fixed Show fixed Hide fixed

jer2ig added 3 commits November 5, 2025 18:45

Pre-commit checks

5a7e279

Pre-commit checks on all files

fc03cc6

Changed function signature, test

5dae651

github-advanced-security bot found potential problems Nov 7, 2025

View reviewed changes

doubleml/plm/tests/test_lplr_tune.py Fixed Show fixed Hide fixed

doubleml/plm/tests/test_lplr_tune.py Fixed Show fixed Hide fixed

doubleml/plm/tests/test_lplr_tune.py Fixed Show fixed Hide fixed

doubleml/plm/tests/test_lplr_tune.py Fixed Show fixed Hide fixed

jer2ig added 2 commits November 6, 2025 16:09

Argument fix

13fca2f

Updated tests for improved coverage

ff4c75b

jer2ig added 4 commits November 7, 2025 12:58

Unused var removed

8a181cd

Fixed resampling

f2ecea7

External predictions

a9a2959

Bugfix and addtl text

cd6055b

LPLR model #365

Are you sure you want to change the base?

LPLR model #365

Uh oh!

Conversation

jer2ig commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JanTeichertKluge Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants