Skip to content

Conversation

LuseBiswas
Copy link

Fixes Issue

**My PR closes #662 **

πŸ‘¨β€πŸ’» Changes proposed(I had made another component inside component πŸ“ named as ReconnectBanner.jsx and import it in BuddyMatcher.jsx)

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

Copy link

vercel bot commented Sep 6, 2024

@LuseBiswas is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • package-lock.json

@LuseBiswas
Copy link
Author

@Dun-sin I think Now I had complete the Compilance/PR Checks .
I had setup the code locally before, but due to the issue I had to delete it. But my codes work fine.
You can check at your own to. Hope it get merged soon.

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper-b2p2 ❌ Failed (Inspect) Sep 6, 2024 10:51am

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 6, 2024

@Dun-sin I think Now I had complete the Compilance/PR Checks .
I had setup the code locally before, but due to the issue I had to delete it. But my codes work fine.
You can check at your own to. Hope it get merged soon.

If you can't test it locally, you can use the preview link from vercel right here in the PR and attach the screen recording

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 6, 2024

@LuseBiswas you also need to remove the package.json file from your PR, don't delete it, remove it. There's a difference please

@Dun-sin Dun-sin changed the title feat: move reconnect banner to a new component refactor: move reconnect banner to a new component Sep 6, 2024
@Dun-sin
Copy link
Owner

Dun-sin commented Sep 6, 2024

@LuseBiswas looks like your build fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] move the reconnect banner to its own component
2 participants