Skip to content

Conversation

Gopal-001
Copy link
Contributor

**My PR closes #666 **

👨‍💻 Changes proposed(What did you do ?)

image Did few changes:
  1. Replaced span with button.
  2. Added some styling to button and on hover button.
  3. Added a gap between the text and button.

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

Normal :

image


On hover:

image

Copy link

vercel bot commented Nov 26, 2024

Someone is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Gopal-001
Copy link
Contributor Author

@Dun-sin pls review the code, glad to have some feedback.
I was facing issue to go to the component as i visited the actually site (not able to connect to some user... something like that) and also tried to bypass the searching for user in local env. But when nothing works so tried to directly call the badwords component via app to see the changes, so if there is some styling change required pls tell.

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gopal-001 please stick to the issue description and just change it from button to span, if you have any UI suggestion change, please create a seperate issue

@Gopal-001
Copy link
Contributor Author

Gopal-001 commented Nov 26, 2024

@Gopal-001 please stick to the issue description and just change it from button to span, if you have any UI suggestion change, please create a seperate issue

@Dun-sin reverted the style changes however removed the cursor-pointer as button automatically handles it.

@Gopal-001 Gopal-001 requested a review from Dun-sin November 26, 2024 15:13
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great @Gopal-001, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. 👉🏽here👈🏽

@Dun-sin Dun-sin merged commit 6634959 into Dun-sin:main Nov 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] change the span to a button for the is bad words element
2 participants