[BUG] Landing page scroll error in 15 inch laptop #747 solved #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the image was missing a max-height setting as max-width setting was given due to which the problem of image getting out of its parent container occurred when there was not enough device height which caused scrollbar to appear
|
@vikas-kumar-git is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
t-trafer
reviewed
Mar 4, 2025
| </div> | ||
| <div className="h-full bg-secondary w-2/4 sm:flex hidden items-center justify-center px-4"> | ||
| <img src="/landing page image.jpg" className="h-auto rounded-full w-auto object-cover" /> | ||
| <img src="/landing page image.jpg" className="h-auto max-h-screen rounded-full w-auto object-cover" /> |
There was a problem hiding this comment.
can you attach the screenshots of before <> after
t-trafer
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the image was missing a max-height setting as max-width setting was given due to which the problem of image getting out of its parent container occurred when there was not enough device height which caused scrollbar to appear
Fixes Issue
My PR closes #issue_number_here
747
👨💻 Changes proposed(What did you do ?)
added tailwind css in img tag
✔️ Check List (Check all the applicable boxes)
Note to reviewers
📷 Screenshots