-
Notifications
You must be signed in to change notification settings - Fork 451
fix: restrict invalid values in age input field #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
@manmeetskalra is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@manmeetskalra i noticed the following bugs:
your best chance at fixing this is providing real time error messages or wait till the user adds a younger age and then throw an error at submission(which i think we already do) |
Thanks for the feedback!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did great, thanks for contributing buddy, I hope you will stick around and continue to contribute to this project.
Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. ππ½hereππ½
Fixes Issue
**My PR closes #760 **
π¨βπ» Changes proposed(What did you do ?)
min="12"
andmax="120"
to age input field.βοΈ Check List (Check all the applicable boxes)
Note to reviewers
I have added minimum age as 12 and the maximum as 120 as it was not mentioned what will be the upper bound
π· Screenshots