Skip to content

Commit 411908e

Browse files
committed
changes in response to PR comments
1 parent f5aa347 commit 411908e

File tree

4 files changed

+10
-28
lines changed

4 files changed

+10
-28
lines changed

components/eamxx/docs/developer/dev_testing/test_all_eamxx.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,9 @@ cd ${e3sm_root}/components/eamxx
203203
```
204204
<!-- markdownlint-enable MD013 -->
205205

206-
If you are unsure of the cmake configuration for you development cycle, one
207-
trick you can use is to run `test-all-eamxx` for the `dbg` test and just
208-
copy the cmake command it prints (then ctrl-C the process).
206+
If you are unsure of the CMake configuration for you development cycle, one
207+
trick you can use is to run `test-all-eamxx --config-only`
208+
for the `dbg` test and then copy the `cmake` commands from the resulting output.
209209

210210
```shell
211211
cd $eamxx_repo/components/eamxx
@@ -220,7 +220,7 @@ Considerations for using `test-all-eamxx`:
220220

221221
- Your machine must be known to our scripts, see above.
222222
- If you try to run commands by-hand (i.e., outside of `test-all-eamxx`,
223-
`cmake`, `make`, `ctest`, etc), you'll need to
223+
`cmake`, `make`, `ctest`, etc.), you'll need to
224224
load the eamxx-env into your shell, which can be achieved by running
225225
`cd eamxx/scripts; eval $(./eamxx-env-cmd $machine)`
226226
- `test-all-eamxx` expects to be run from a compute node if you

components/eamxx/docs/developer/dev_testing/testing_for_development.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ be the `eamxx_inject_ash_process_interface.<x>pp` files, located at
2727

2828
#include "share/atm_process/atmosphere_process.hpp"
2929

30-
namespace eamxx {
30+
namespace scream {
3131
class MAMInjectAsh : public AtmosphereProcess {
3232
public:
3333
MAMInjectAsh(const ekat::Comm &comm, const ekat::ParameterList &params);
@@ -47,7 +47,7 @@ be the `eamxx_inject_ash_process_interface.<x>pp` files, located at
4747
Field lat;
4848
Field lon;
4949
}
50-
} // namespace eamxx
50+
} // namespace scream
5151

5252
#endif // EAMXX_MAM_INJECT_ASH_HPP
5353
```
@@ -56,7 +56,7 @@ be the `eamxx_inject_ash_process_interface.<x>pp` files, located at
5656
#include "ash_source_calculation.hpp"
5757
#include "eamxx_inject_ash_process_interface.hpp"
5858

59-
namespace eamxx {
59+
namespace scream {
6060

6161
MAMInjectAsh::MAMInjectAsh(const ekat::Comm &comm,
6262
const ekat::ParameterList &params)
@@ -83,7 +83,7 @@ be the `eamxx_inject_ash_process_interface.<x>pp` files, located at
8383
ash.update(source_mask, rate * dt,
8484
decay); // ash = decay*ash + rate*dt*source_mask
8585
}
86-
} // namespace eamxx
86+
} // namespace scream
8787
```
8888

8989
### Add the New Process to CMake Build
@@ -270,7 +270,7 @@ though [NetCDF](https://www.unidata.ucar.edu/software/netcdf/) can also be used.
270270
#include "ash_source_calculation.hpp"
271271

272272
namespace {
273-
using namespace eamxx;
273+
using namespace scream;
274274
TEST_CASE("verify compute_ash_injection_rate", "mam")
275275
{
276276
// initialize the data and test variables
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Input-Output
22

33
In EAMxx, I/O is handled through the SCORPIO library, currently a submodule of
4-
E3SM. The `eamxx_io` library within eamxx allows to interface the EAMxx
4+
E3SM. The `scream_io` library within eamxx allows to interface the EAMxx
55
infrastructure classes with the SCORPIO library.

components/eamxx/docs/user/index.md

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,3 @@ In the meantime, in case you do not find the information you need,
1313
we suggest visiting our public
1414
[EAMxx user guide](https://acme-climate.atlassian.net/wiki/spaces/DOC/pages/3858890786/EAMxx+User+s+Guide)
1515
on Confluence.
16-
17-
<!-- ## [EAMxx Case Basics](eamxx_cases.md)
18-
19-
## [Testing](user_testing.md)
20-
21-
## [Model Configuration](model_input.md)
22-
23-
## [Nudging](nudging.md)
24-
25-
## [Extra Radiation Calls](clean_clear_sky.md)
26-
27-
## [COSP](cosp.md)
28-
29-
## [Regionally Refined EAMxx](rrm_eamxx.md)
30-
31-
## [Doubly Periodic EAMxx](dp_eamxx.md)
32-
33-
## [PyEAMxx](pyeamxx.md) -->

0 commit comments

Comments
 (0)