EAMxx: fix sanity check in print_field_hyperslab

Also, add test to verify the check works

Author: bartgol

components/eamxx/src/share/field/field_utils.cpp

@@ -323,11 +323,12 @@ void print_field_hyperslab (const Field& f,
 
   const int num_indices = indices.size();
   for (int i=0; i<num_indices; ++i) {
-    EKAT_REQUIRE_MSG ( indices[i]>=0 && indices[i]<fl.dim(i),
-      "Error! Requested index is invalid.\n"
+    EKAT_REQUIRE_MSG ( indices[i]>=0 && indices[i]<fl.dim(tags[i],false),
+      "Error! Requested slice index is out of bound.\n"
       "  - field name: " + f.name() + "\n"
       "  - field layout: " + fl.to_string() + "\n"
-      "  - requested indices: (" + ekat::join(indices,",") + ")\n");
+      "  - hyperslab tags: (" + ekat::join(tags2str(tags),",") + ")\n"
+      "  - hyperslab indices: (" + ekat::join(indices,",") + ")\n");
   }
 
   switch (dt) {

components/eamxx/src/share/field/tests/field_utils.cpp

@@ -773,6 +773,11 @@ TEST_CASE ("print_field_hyperslab") {
       }
 
     REQUIRE (out.str()==expected.str());
+
+    loc_idxs[0] = nel;
+    REQUIRE_THROWS(print_field_hyperslab(f,loc_tags,loc_idxs,out));
+    loc_idxs[0] = -1;
+    REQUIRE_THROWS(print_field_hyperslab(f,loc_tags,loc_idxs,out));
   }
   SECTION ("slice_0234") {
     std::vector<FieldTag> loc_tags = {EL,GP,GP,LEV};