Skip to content

EAMxx: in infra, ensure comments/code reflect generality of masking treatment #7653

@mahf708

Description

@mahf708

comments like

// If the mask comes from FieldAtLevel, it's only defined on columns (rank=1)
// If the mask comes from vert interpolation remapper, it is defined on ncols x nlevs (rank=2)

may make it sound like this is the only case supported. I suggest a quick walk through the infra code (remap, io, etc.) to reflect the new reality of more extensive masking we are now using.

Make the assumption clearer and more general, e.g.,

// NOTE that in eamxx, masking is at most rank-2, either on COL only or on COLxLEV only

Even better, add documentation to clarify how masking works and use cases under components/eamxx/docs.

--

@bartgol I didn't assign anyone here, because this is the type of thing a curious reader may be able to do and document ... or you know, maybe that one helpful 🤖🤖🤖🤖🤖🤖🤖🤖🤖 ;) (copilot, if you're reading...)

ran into this in #7652 with annoying layout-like errors that took a bit of time to trace...

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions