Add python version of mkatmsrffile to replace fortran #6506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whannah1
added
BFB
|
|
@wlin7 please review |
|
@wlin7 I'd really like someone who uses this tool to approve. Can you suggest anyone else? |
@rljacob , @brhillman went very deep onto using this tool. He will be a best person to review this. |
wlin7
reviewed
Aug 20, 2024
wlin7
reviewed
Aug 21, 2024
|
@wlin7 can you give this another look? |
|
@wlin7 please approve. |
mahf708
reviewed
Sep 2, 2024
mahf708
force-pushed
the
whannah/tools/add-mkatmsrffile
branch
from
053980a to
846531d
Compare
mahf708
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
With a test in hand, this is ready to go:
https://github.com/E3SM-Project/E3SM/actions/runs/10692384555/job/29640697312?pr=6506#step:5:1475
File and parameter values:
map_file : map_1x1_to_ne30pg2_traave_c20240903.nc
vegetation_file : regrid_vegetation.nc
soil_water_file : clim_soilw.nc
output_root : ./
output_file : .//atm_srf_ne30pg2_20240903.nc
dst_grid : ne30pg2
map_file n_a : 64800
map_file n_b : 21600
successfully created atmsrf file: .//atm_srf_ne30pg2_20240903.nc
rljacob
added a commit
that referenced
this pull request
Sep 4, 2024
Add new tool in components/eam/tools/mkatmsrffile/mkatmsrffile.py, which is a python rewrite of the older fortran tool, which now lives in components/eam/tools/mkatmsrffile/old_mkatmsrffile. The old version was problematic to use because the build configuration was often broken. The new python version efficiently applies the input map weighting efficiently due to the numba package, which is included in the E3SM unified environment. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new tool in
components/eam/tools/mkatmsrffile/mkatmsrffile.py, which is a python rewrite of theolder fortran tool, which now lives in
components/eam/tools/mkatmsrffile/old_mkatmsrffile. The old version wasproblematic to use because the build configuration was often broken. The new python version efficiently
applies the input map weighting efficiently due to the numba package, which is included in the E3SM unified environment.
[BFB]