Skip to content

Conversation

yunpengshan2014
Copy link
Contributor

@yunpengshan2014 yunpengshan2014 commented Aug 12, 2024

Add output lines for in-cloud qc​, nc​, qi​, and ni in P3​ to ensure that their values are correctly output. Without these lines, their values will be zero.

The changes have no impact on simulation results - except for the outputs that are fixed: ICIMRST, ICWMRST, ICINC, ICWNC.

[BFB] No tests are affected. These in-cloud variables are not in default eam.h0.

@yunpengshan2014 yunpengshan2014 marked this pull request as draft August 12, 2024 16:30
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6545/
on branch gh-pages at 2024-08-12 16:30 UTC

@yunpengshan2014 yunpengshan2014 requested a review from wlin7 August 12, 2024 16:31
@crterai crterai added Atmosphere BFB PR leaves answers BFB labels Aug 12, 2024
@rljacob
Copy link
Member

rljacob commented Aug 20, 2024

Is this ready? Its marked as "Draft".

@yunpengshan2014 yunpengshan2014 marked this pull request as ready for review August 21, 2024 22:44
@rljacob
Copy link
Member

rljacob commented Aug 22, 2024

@wlin7 this is ready.

wlin7 added a commit that referenced this pull request Sep 5, 2024
…6545)

Add outfld lines for in-cloud properties output

Add output lines for in-cloud qc, nc, qi, and ni in P3 to ensure that their
values are correctly output. Without these lines, their values will be zero.

The changes have no impact on simulation results - except for the outputs
that are fixed: ICIMRST, ICWMRST, ICINC, ICWNC.

[BFB] No tests are affected. These in-cloud variables are not in default eam.h0.
@wlin7
Copy link
Contributor

wlin7 commented Sep 5, 2024

Merged to next.

@wlin7 wlin7 merged commit ed06ec6 into master Sep 6, 2024
21 checks passed
@wlin7 wlin7 deleted the yunpengshan2014/E3SM/AddIncldVarOutput branch September 6, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere BFB PR leaves answers BFB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants