Skip to content

Conversation

njeffery
Copy link
Contributor

@njeffery njeffery commented Aug 15, 2024

Registry defaults were updated when implicit grazing was adding for E3SMv2, but the build defaults were kept the same.

Fixes #6548

[NML]
[non-BFB] for cases with ice bgc

Bugfix.
Registry defaults were updated when implicit grazing
was adding for E3SMv2, but the build defaults were kept the same.

non-bfb in ice bgc runs.  BFB for all others
@njeffery njeffery requested a review from maltrud August 15, 2024 15:01
@njeffery njeffery assigned njeffery and jonbob and unassigned njeffery Aug 15, 2024
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6549/
on branch gh-pages at 2024-08-15 15:03 UTC

@rljacob rljacob changed the title Updates bgc defaults for grazing parameters Update bgc defaults for grazing parameters Aug 21, 2024
Copy link
Contributor

@maltrud maltrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection and testing of author and other reviewers.

@jonbob jonbob added the NML label Aug 26, 2024
jonbob added a commit that referenced this pull request Aug 26, 2024
…6549)

Update bgc defaults for grazing parameters

Registry defaults were updated when implicit grazing was adding for
E3SMv2, but the build defaults were kept the same.

Fixes #6548

[NML]
[non-BFB] for cases with ice bgc
@jonbob
Copy link
Contributor

jonbob commented Aug 26, 2024

Passes:

  • ERP_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-pioroot1
  • e3sm_ice_developer
  • SMS_Ld2.ne30pg2_r05_IcoswISC30E3r5.BGCEXP_CNTL_CNPECACNT_1850.chrysalis_intel.elm-bgcexp

with expected NML DIFFs. Merged to next

@jonbob jonbob merged commit ec9da4b into master Aug 27, 2024
13 checks passed
@jonbob jonbob deleted the njeffery/seaice/fix-bgc-graze-defaults branch August 27, 2024 18:54
@jonbob
Copy link
Contributor

jonbob commented Aug 27, 2024

merged to master and expected NML DIFFs blessed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPAS-seaice bgc default grazing parameters are incorrect
4 participants