Skip to content

Conversation

jinyuntang
Copy link
Contributor

@jinyuntang jinyuntang commented Nov 8, 2024

This avoids redundant output to log file.
Also suspend unit testing until pfunit fixed.
Update sbetr submodules to use ssh. Get ready to fix obsolete 3rd party libs

[BFB]

This avoids redundant output to log file.

[BFB]
@jinyuntang jinyuntang requested a review from ndkeen November 8, 2024 17:16
@jinyuntang jinyuntang added BFB PR leaves answers BFB ELM land model labels Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6740/
on branch gh-pages at 2024-11-08 17:17 UTC

@jinyuntang
Copy link
Contributor Author

@ndkeen I checked the test ERS.f19_g16.I1850ELM.pm-cpu_gnu.elm-betr, it no longer produce the large log file. Please review. Thanks.

@ndkeen
Copy link
Contributor

ndkeen commented Nov 8, 2024

I see you removed the debug print. It kinda looks like other things were also changed? I might ask others involved to verify those changes are inert -- or would benefit from a different PR -- or at least update to the title.

@rljacob rljacob self-assigned this Nov 8, 2024
@rljacob rljacob requested a review from bishtgautam November 8, 2024 18:12
@rljacob rljacob assigned peterdschwartz and unassigned rljacob Nov 8, 2024
@rljacob
Copy link
Member

rljacob commented Nov 8, 2024

The current version of sbetr being used is 66260f4991d6. You should make a branch from that, fix just the debug statement, and then update the submodule to point to that branch. Otherwise this is a much bigger "update sbetr" PR.

@rljacob
Copy link
Member

rljacob commented Nov 8, 2024

The other updates looks like its just testing, not code, so maybe this is fine as is.

@ndkeen
Copy link
Contributor

ndkeen commented Nov 8, 2024

Yes, I also see they are testing related -- I just don't know if it was intentional, related, important, etc. So if you think it's ok, I will approve.

@rljacob
Copy link
Member

rljacob commented Nov 8, 2024

Wait for @peterdschwartz or @bishtgautam to approve.

@ndkeen
Copy link
Contributor

ndkeen commented Nov 13, 2024

Can we merge this?

@rljacob rljacob assigned ndkeen and unassigned peterdschwartz Nov 13, 2024
@rljacob
Copy link
Member

rljacob commented Nov 13, 2024

@ndkeen go ahead

@ndkeen
Copy link
Contributor

ndkeen commented Nov 13, 2024

Can we find someone more familiar with working with submodules?

@rljacob rljacob assigned rljacob and unassigned ndkeen Nov 13, 2024
rljacob added a commit that referenced this pull request Nov 15, 2024
This avoids redundant output to log file.

[BFB]
@rljacob rljacob merged commit 98ac5d3 into master Nov 15, 2024
9 checks passed
@rljacob rljacob deleted the jinyuntang/betr_printfix branch November 15, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB ELM land model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants