-
Notifications
You must be signed in to change notification settings - Fork 437
update sbetr to remove redundant print to log #6740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This avoids redundant output to log file. [BFB]
|
@ndkeen I checked the test ERS.f19_g16.I1850ELM.pm-cpu_gnu.elm-betr, it no longer produce the large log file. Please review. Thanks. |
I see you removed the debug print. It kinda looks like other things were also changed? I might ask others involved to verify those changes are inert -- or would benefit from a different PR -- or at least update to the title. |
The current version of sbetr being used is 66260f4991d6. You should make a branch from that, fix just the debug statement, and then update the submodule to point to that branch. Otherwise this is a much bigger "update sbetr" PR. |
The other updates looks like its just testing, not code, so maybe this is fine as is. |
Yes, I also see they are testing related -- I just don't know if it was intentional, related, important, etc. So if you think it's ok, I will approve. |
Wait for @peterdschwartz or @bishtgautam to approve. |
Can we merge this? |
@ndkeen go ahead |
Can we find someone more familiar with working with submodules? |
This avoids redundant output to log file. [BFB]
This avoids redundant output to log file.
Also suspend unit testing until pfunit fixed.
Update sbetr submodules to use ssh. Get ready to fix obsolete 3rd party libs
[BFB]