Skip to content

EAMxx: add horizontal contraction utility to Field #6776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 27, 2024
Merged

EAMxx: add horizontal contraction utility to Field #6776

merged 4 commits into from
Nov 27, 2024

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Nov 24, 2024 •
edited
Loading

adds a horizontal contraction utility equivalent to einsum('i,i...k->...k', weight, field)

Notes:

@mahf708 mahf708 added the EAMxx Issues related to EAMxx label Nov 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6776/
on branch gh-pages at 2024-11-27 02:53 UTC

@mahf708 mahf708 force-pushed the mahf708/eamxx/field-colred branch from f887853 to 1373e9c Compare November 24, 2024 17:47
bartgol
bartgol reviewed Nov 25, 2024
View reviewed changes
@mahf708 mahf708 requested a review from bartgol November 26, 2024 03:21
@mahf708 mahf708 changed the title EAMxx: add column reduction utility to fields EAMxx: add horizontal contraction utility to fields Nov 26, 2024
@mahf708 mahf708 changed the title EAMxx: add horizontal contraction utility to fields EAMxx: add horizontal contraction utility to Field Nov 26, 2024
@mahf708 mahf708 force-pushed the mahf708/eamxx/field-colred branch from 2f937ae to 84d8566 Compare November 26, 2024 04:51
bartgol
bartgol approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have some last minute thoughts, feel free to reject.

bartgol
bartgol requested changes Nov 27, 2024
View reviewed changes
mahf708
mahf708 commented Nov 27, 2024
View reviewed changes
@mahf708 mahf708 requested a review from bartgol November 27, 2024 17:19
@bartgol
Copy link
Contributor

bartgol commented Nov 27, 2024

The failing test is the same as on master (and is currently under investigation by the MAM4xx team). We can merge.

@bartgol bartgol merged commit 5a3f949 into master Nov 27, 2024
17 of 20 checks passed
@bartgol bartgol deleted the mahf708/eamxx/field-colred branch November 27, 2024 20:46
@mahf708
Copy link
Contributor Author

mahf708 commented Nov 27, 2024

Thanks @bartgol ❤️

@mahf708 mahf708 mentioned this pull request Nov 30, 2024
Merged
@bartgol bartgol mentioned this pull request Dec 6, 2024
Closed
bartgol added a commit that referenced this pull request Dec 12, 2024
@bartgol
Merge branch 'mahf708/eamxx/horiz-avg-diag' (PR #6788)
8818556 
Adds an online diagnostic field for area-weighted horizontal average, following #6776.
@mahf708 mahf708 mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartgol bartgol bartgol approved these changes

@tcclevenger tcclevenger Awaiting requested review from tcclevenger

Assignees

@bartgol bartgol

Labels
EAMxx Issues related to EAMxx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahf708 @bartgol