Skip to content

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Nov 27, 2024

Removes an unused test so that it is not accidentally triggered, and we also don't want to maintain it.

@mahf708 mahf708 added the Testing Anything related to unit/system tests label Nov 27, 2024
@mahf708 mahf708 requested a review from rljacob November 27, 2024 21:53
Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6783/
on branch gh-pages at 2024-11-27 21:55 UTC

@rljacob
Copy link
Member

rljacob commented Nov 27, 2024

I see you added this as part of #6506. Sure you want to remove it? It seems to have all the safeguards around it: only runs when the code is touched and only in this repo.

@mahf708
Copy link
Contributor Author

mahf708 commented Nov 27, 2024

I see you added this as part of #6506. Sure you want to remove it? It seems to have all the safeguards around it: only runs when the code is touched and only in this repo.

The problem is the cron :(

  schedule:
    - cron: '00 15 * * 2'

I think we should delete it for now. We will want to redesign these test to run in containers from now on. I wanna create a "misc" container that has stuff tests like this would need, but that's a distant todo item given everything else ...

rljacob added a commit that referenced this pull request Dec 2, 2024
…6783)

Removes an unused test so that it is not accidentally triggered,
and we also don't want to maintain it.
@rljacob rljacob merged commit b3be695 into master Dec 2, 2024
5 checks passed
@rljacob rljacob deleted the mahf708/ig/remove-unused-ci-job branch December 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to unit/system tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants