-
Notifications
You must be signed in to change notification settings - Fork 436
Adds tech note about longwave radiation #7133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
b2ec3a6
to
cf52ff5
Compare
4953634
to
5505793
Compare
5505793
to
b7e4ab9
Compare
@thorntonpe, @daleihao, The rendered technote chapter is available at https://docs.e3sm.org/E3SM/pr-preview/pr-7133/ELM/tech-guide/longwave_radiation/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I just leave few minor comments.
@@ -0,0 +1,283 @@ | |||
# Overview | |||
|
|||
The longwave radiation in ELM solves the amount of longwave |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longwave radition module in ELM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can provide the values of snow, soil emissitivity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I will add it.
dc341b3
to
8f09294
Compare
Some clarifying questions for my benefit. Where do |
That's a good question. The equations in this chapter only apply to naturally vegetated and crop land units; they do not apply to urban land units. For Urban landunits, we need a new chapter that will correspond to CLM's chapter on the urban model, and this will written for ELM in the future.
I don't have a complete vision for this, but here are my thoughts and reasoning, and I welcome feedback. It would undoubtedly be helpful to document these implementation details. However, I'm not sure if we need a new Implementation Guide for it or if we should add a new section at the end of each technical guide chapter summarizing these details. These details would be helpful when converting the Fortran code to Kookos (at some point in the future), but I think we should not spend a lot of effort meticulously documenting the implementation in the Fortran implementation because we are going to leave that implementation behind. |
@peterdschwartz, I'm adding you as a reviewer because we need the approval of one reviewer that have write access to the repo. |
Adds documentation about ELM's longwave radiation model. [BFB]
Merged to next and master |
Adds documentation about ELM's longwave radiation model.
[BFB]