Skip to content

Conversation

bishtgautam
Copy link
Contributor

@bishtgautam bishtgautam commented Mar 14, 2025

Adds documentation about ELM's longwave radiation model.

[BFB]

@bishtgautam bishtgautam added Land Documentation BFB PR leaves answers BFB labels Mar 14, 2025
Copy link

github-actions bot commented Mar 14, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://E3SM-Project.github.io/E3SM/pr-preview/pr-7133/

Built to branch gh-pages at 2025-04-03 18:40 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@bishtgautam bishtgautam force-pushed the bishtgautam/lnd/longwave-tech-note branch 8 times, most recently from b2ec3a6 to cf52ff5 Compare March 15, 2025 22:11
@bishtgautam bishtgautam force-pushed the bishtgautam/lnd/longwave-tech-note branch 4 times, most recently from 4953634 to 5505793 Compare March 27, 2025 03:06
@bishtgautam bishtgautam force-pushed the bishtgautam/lnd/longwave-tech-note branch from 5505793 to b7e4ab9 Compare March 27, 2025 03:07
@bishtgautam bishtgautam marked this pull request as ready for review March 27, 2025 03:08
@bishtgautam
Copy link
Contributor Author

Copy link
Collaborator

@daleihao daleihao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I just leave few minor comments.

@@ -0,0 +1,283 @@
# Overview

The longwave radiation in ELM solves the amount of longwave
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longwave radition module in ELM?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can provide the values of snow, soil emissitivity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I will add it.

@bishtgautam bishtgautam force-pushed the bishtgautam/lnd/longwave-tech-note branch from dc341b3 to 8f09294 Compare April 3, 2025 18:37
@peterdschwartz
Copy link
Contributor

Some clarifying questions for my benefit.

Where do UrbanRadiation calculations fit in here? Eqs (16)-(17) or are those for bare ground?
Some potential confusion about the "longwave radiation module" on my part. I assume this isn't meant in the sense of a fortran module like SurfaceRadiationMod or CanopyFluxesMod. Is the vision to have the fortran/code details in the ELM Developer Guide which will cite the relevant Technical Guide docs?

@bishtgautam
Copy link
Contributor Author

@peterdschwartz,

Where do UrbanRadiation calculations fit in here? Eqs (16)-(17) or are those for bare ground?

That's a good question. The equations in this chapter only apply to naturally vegetated and crop land units; they do not apply to urban land units. For Urban landunits, we need a new chapter that will correspond to CLM's chapter on the urban model, and this will written for ELM in the future.

Is the vision to have the fortran/code details in the ELM Developer Guide which will cite the relevant Technical Guide docs?

I don't have a complete vision for this, but here are my thoughts and reasoning, and I welcome feedback. It would undoubtedly be helpful to document these implementation details. However, I'm not sure if we need a new Implementation Guide for it or if we should add a new section at the end of each technical guide chapter summarizing these details. These details would be helpful when converting the Fortran code to Kookos (at some point in the future), but I think we should not spend a lot of effort meticulously documenting the implementation in the Fortran implementation because we are going to leave that implementation behind.

@bishtgautam
Copy link
Contributor Author

@peterdschwartz, I'm adding you as a reviewer because we need the approval of one reviewer that have write access to the repo.

peterdschwartz added a commit that referenced this pull request Apr 10, 2025
Adds documentation about ELM's longwave radiation model.

[BFB]
@peterdschwartz peterdschwartz merged commit 4dd681a into master Apr 10, 2025
3 checks passed
@peterdschwartz peterdschwartz deleted the bishtgautam/lnd/longwave-tech-note branch April 10, 2025 18:40
@peterdschwartz
Copy link
Contributor

Merged to next and master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB Documentation Land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants