-
Notifications
You must be signed in to change notification settings - Fork 435
Add new compsets and namelists for km-scale ELM simulation #7208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
<value stream="ELMGSWP3w5e5.Solar">gswp_w5e5.Solr.%ym.nc</value> | ||
<value stream="ELMGSWP3w5e5.Precip">gswp_w5e5.Prec.%ym.nc</value> | ||
<value stream="ELMGSWP3w5e5.TPQW">gswp_w5e5.TPQWL.%ym.nc</value> | ||
<value stream="uELM_NA.FSDS">clmforc.Daymet.km.1d.FSDS.%ym.nc</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How big are some of these new data files? Are they in the correct format (CDF5)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the dataset can be softlinks to small datasets, they are in CDF5 format.
38f20df
to
c9e7476
Compare
@rljacob the files are custom for each domain. For the test case using these forcings (21 gridcells), the forcings are ~32KB and the surface dataset is ~1GB. For the file format, ncdump -k says netCDF-4, so I will need to convert them |
<desc option="kmELM"> Daymet NA data set, sub-daily downscaled with GSWP3 </desc> | ||
<desc option="uELMTES"> Daymet NA data set, sub-daily downscaled with ERA5 for TESSFA project </desc> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about naming these datasets as DaymetGSWP3 and DaymetERA5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good ideas.
#./xmlchange PIO_TYPENAME="pnetcdf" | ||
#./xmlchange PIO_NETCDF_FORMAT="64bit_data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about deleting these lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines are needed for large-scale experiments, after discussion with Jayesh.
@@ -0,0 +1,2 @@ | |||
fsurdat = '$DIN_LOC_ROOT/lnd/clm2/surfdata_map/MOF21_surfdata.Daymet_NA.1km.1d.c240524.nc' | |||
!fatmlndfrc = '$DIN_LOC_ROOT/share/domains/domain.clm/MOF21_domain.lnd.Daymet_NA.1km.1d.c240524.nc' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about deleting this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are related to a small test case that Peter is used for kmELM evaluation.
Examining the data on NERSC, it is a highly customized DATM dataset created specifically for the study. e.g. the dataset has only 24 grd cells. Am I missing something here?
Should we support such a custom dataset in the main branch? |
@bishtgautam You are correct that it is just a customized forcing data set (interpolation of forcings are already done -@daliwang can better comment on what else is done). The main benefit i see with using these datasets for testing is to remove the bottleneck for reading and interpolating the forcings. For example, the test i added which runs the 21 sites for 1 year only took 78s. Contrast that to the I just created this test for the MOFlux sites as an example, and I think it would be great to discuss which region(s) would be best to include in testing. I'm fine to remove the test from the nightly test suites from this PR -- the testmod would be nice to keep for easy case generation though not that big of a deal. I do think we should merge the compset definitions as they can be very useful and even necessary for adequate I/O performance for 1km runs |
In my opinion, if we add a new DATM dataset, we should be able to run a simulation that is global or regional (as in this case, because it is DAYMET). But that isn't possible here. If the purpose of these files is to improve testing and/or provide an example of how to speed up offline ELM simulation, why not use the |
I would definitely prefer to implement this without a compset as this can work with any ELM configuration (well, i used it for combinations of bgc/fates and different nu_com so far). Unfortunately, i am not very familiar with using the |
Next week, I can convert the new tests to use |
Any progress on this PR? |
converting to draft until this is reimplemented as described. |
I think we could not just simply use the "user_data.streams.txt" to achieve the results and performance, as the default Datm requires grid checking and spatial interpolation, and it is the remain reason that the coupler-bypass was implemented at ORNL. The current new Compset and associate change, maybe we can change to a more common name, solved the unnecessary grid checking/validation/interpolation issues, enabled the large-scale offline ELM simulation at scales. |
…forcings for fast offline runs Added testmod and test for MOF21 sites
e7f18c1
to
4d8a949
Compare
@bishtgautam I removed the new land compsets and changed the names of the new datm to |
@bishtgautam can you approve this? |
@peterdschwartz please start merging this. |
The new features support scalable, km-scale E3SM land modeling (using the data atmosphere model) across various computational resources, from a single core to up to 2400 nodes on leadership-class supercomputers.
Wang, D., Wang, C., Cao, Q., Krishna, J., Wu, D., Zheng, W., Schwartz, P., Yuan, F., Mohror, K., & Thornton, P. (2025). Scaling Ultrahigh-Resolution E3SM Land Model for Leadership-Class Supercomputers, IEEE Symposium on Cluster, Cloud, and Internet Computing 2025, TCSC SCALE Challenge finalist.
Tested and passed e3sm_land_developer tests on Frontier using craygnu compiler.
[BFB]