Skip to content

Conversation

tcclevenger
Copy link
Contributor

@tcclevenger tcclevenger commented Apr 15, 2025

Previously, grid views were initialized with F90 data before dss_hvtensor() was called (which updates elem(ie)%tensorVisc), so the changes were not captured in C++, resulting in BFB behavior when we expected non-BFB.

[non-BFB for EAMxx]

@tcclevenger tcclevenger self-assigned this Apr 15, 2025
@tcclevenger tcclevenger added non-BFB PR makes roundoff changes to answers. EAMxx Issues related to EAMxx bug fix PR labels Apr 15, 2025
@tcclevenger
Copy link
Contributor Author

@mt5555 I ran the change here w/o calling dss_hvtensor and we are BFB (as expected). These grid views are not used in EAMxx in between the previous initialization and the current initialization.

@tcclevenger tcclevenger requested review from bartgol and mt5555 April 15, 2025 19:15
@tcclevenger
Copy link
Contributor Author

tcclevenger commented May 29, 2025

@bartgol I want to rerun these tests since we are about to merge and they haven't been run in a while, but I'm not given the option anymore when I click "View details". Do you still have the option?

(Retriggered the tests by rebasing to master, just curious if the other way is still an option)

@tcclevenger tcclevenger force-pushed the tcclevenger/eamxx/dss_hvtensor_should_diff branch from 7aa11fa to 42b24d6 Compare May 29, 2025 12:39
@bartgol
Copy link
Contributor

bartgol commented May 29, 2025

@bartgol I want to rerun these tests since we are about to merge and they haven't been run in a while, but I'm not given the option anymore when I click "View details". Do you still have the option?

(Retriggered the tests by rebasing to master, just curious if the other way is still an option)

I don't know if there is a time limit for re-triggering jobs. So you did not see on the top right the button "Re-run jobs"? That's weird. It's hard for me to double check without a PR that has been sitting around for a while. I checked on a 2-weeks old PR, and the button is still present for re-triggering jobs, but maybe it expires after 1 month or so. Not sure. But it seems odd that it can expire. Maybe it is more likely it was a glitch?

@tcclevenger
Copy link
Contributor Author

@bartgol You're right, sitting too long. Button is back after rebasing.

@tcclevenger tcclevenger marked this pull request as draft June 17, 2025 14:14
@tcclevenger tcclevenger force-pushed the tcclevenger/eamxx/dss_hvtensor_should_diff branch from 42b24d6 to 7194f78 Compare July 16, 2025 16:51
@tcclevenger tcclevenger marked this pull request as ready for review July 16, 2025 16:52
@rljacob
Copy link
Member

rljacob commented Jul 24, 2025

Update: Mark will review some runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix PR EAMxx Issues related to EAMxx non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants