-
Notifications
You must be signed in to change notification settings - Fork 435
EAMxx: Move grid view initialization after dss_hvtensor #7249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@mt5555 I ran the change here w/o calling |
@bartgol I want to rerun these tests since we are about to merge and they haven't been run in a while, but I'm not given the option anymore when I click "View details". Do you still have the option? (Retriggered the tests by rebasing to master, just curious if the other way is still an option) |
7aa11fa
to
42b24d6
Compare
I don't know if there is a time limit for re-triggering jobs. So you did not see on the top right the button "Re-run jobs"? That's weird. It's hard for me to double check without a PR that has been sitting around for a while. I checked on a 2-weeks old PR, and the button is still present for re-triggering jobs, but maybe it expires after 1 month or so. Not sure. But it seems odd that it can expire. Maybe it is more likely it was a glitch? |
@bartgol You're right, sitting too long. Button is back after rebasing. |
42b24d6
to
7194f78
Compare
Update: Mark will review some runs. |
Previously, grid views were initialized with F90 data before
dss_hvtensor()
was called (which updateselem(ie)%tensorVisc
), so the changes were not captured in C++, resulting in BFB behavior when we expected non-BFB.[non-BFB for EAMxx]