ZM cleanup - refactor handling of parameters and constants #7300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whannah1
force-pushed
the
whannah/eam/zm-cleanup-10
branch
from
69af0d2 to
f4b357d
Compare
whannah1
force-pushed
the
whannah/eam/zm-cleanup-10
branch
from
f4b357d to
2802668
Compare
|
|
Note to self - this needs to stay in draft mode until PR #7281 is merged and this branch can be rebased. |
whannah1
force-pushed
the
whannah/eam/zm-cleanup-10
branch
from
2309211 to
c49c2d3
Compare
|
The following tests pass on Chrysalis, but with the expected "NLFAIL" |
|
The performance of the SMS_Ld32 tests are indentical |
|
waiting on reviewer approval. |
crterai
approved these changes
Jun 26, 2025
singhbalwinder
added a commit
that referenced
this pull request
Jun 30, 2025
ZM cleanup - refactor handling of parameters and constants This phase focused on how ZM handles namelist parameters and constant values - building off of PR #7232 that created the zm_conv_types module to hold definitions and methods of the zm_const_t and zm_param_t derived types. Here we expand the use of these throughout the code, as well as move the zm_conv_readnl (originally zmconv_readnl) to the interface level to decrease the external dependencies needed to build zm_conv.F90, which should help make C++ bridging easier. This PR also fixes the redundant namelist parameters for the DCAPE and ULL closure options, which originally had 3 parameters controlling 2 independent options. Now there will be a single flag for either option. [BFB] * whannah/eam/zm-cleanup-10: fix index for printing ZM derived types add missing zm_param to use statement cosmetic fix linter fix refactor zm_conv_readnl
|
Merged to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This phase focused on how ZM handles namelist parameters and constant values - building off of PR #7232 that created the
zm_conv_typesmodule to hold definitions and methods of thezm_const_tandzm_param_tderived types. Here we expand the use of these throughout the code, as well as move thezm_conv_readnl(originallyzmconv_readnl) to the interface level to decrease the external dependencies needed to buildzm_conv.F90, which should help make C++ bridging easier.This PR also fixes the redundant namelist parameters for the DCAPE and ULL closure options, which originally had 3 parameters controlling 2 independent options. Now there will be a single flag for either option.
[BFB]