EAMxx: add ghci-snl-hip CI testing #7304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
added
EAMxx
bartgol
changed the title
bartgol
force-pushed
the
bartgol/eamxx/add-ghci-snl-hip-ci
branch
2 times, most recently
from
88161db to
3f2e58a
Compare
|
I made a mistake while building the HIP container image. I have fixed it, but now we have to wait for the AT2 nightly framework to kick in, patch my image with the AT2 scripts, and uploading the new container on SNL's gitlab instance, so that our CI can run in the new container. I will trigger a new build tomorrow. |
|
The build on HIP currently fails due to the register keyword being incompatible with C++17 (which clang++ apparently enforces more strictly than g++). We need to wait for the scorpio submodule to be updated to include E3SM-Project/scorpio#644. |
jgfouca
approved these changes
May 15, 2025
|
waiting on addition of SCORPIO 1.8.0 |
|
Todo: rebase and retest once #7419 is merged. |
bartgol
force-pushed
the
bartgol/eamxx/add-ghci-snl-hip-ci
branch
from
d79b210 to
0b3559b
Compare
These warnings contain a code snippet which contain the keyword ERROR, which ctest interprets as a build error
Conform them to v0.2.1 changes
Beside the fact that we will transition to that for all jobs anyways, the HIP build is having a hard time getting the compilers to work with test-all-eamxx
bartgol
force-pushed
the
bartgol/eamxx/add-ghci-snl-hip-ci
branch
from
0b3559b to
c002bce
Compare
|
I'm going to close this for now, as I don't have the bandwidth to complete it. We can reopen later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds machine file and edit workflow file, to enable CI testing with HIP backend.
NOTE: I am having trouble running a DEBUG build of eamxx standalone. Some tests pass, but some fail with odd rocm errors. This PR only adds a RELEASE build for the CI workflow, hoping that it works as expected...