EAMxx: MDRangePolicy in MAM4xx interfaces. #7344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you measure the perf hit? If you did, and there is a sizeable hit, then go ahead. Otherwise, I think MD policies are much more self-expressive and compact (and less bug prone) than manual index arithmetic... |
…as been reported that the latter has performance issues. We can revert this commit once the Kokkos team addresses these concerns.
odiazib
force-pushed
the
eamxx/remove_MDRangePolicy
branch
from
d90282e to
811f283
Compare
|
There is no performance hit for MDRangePolicy in the mam4xx interfaces. See the next figure. |
|
To be clear, compared to master, MD policy was only added in a subset of the aerosols section, right? |
Yes, we have only replaced MDRange policies in two of the MAM4xx interfaces: microphysics and optics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a regular range policy instead of MDRangePolicy, as it has been reported that the latter has performance issues. We can revert this commit once the Kokkos team addresses these concerns.