EAMxx: Fix FPE in shoc_compute_shoc_mix_shoc_length_impl.hpp #7368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahf708
approved these changes
May 20, 2025
bartgol
reviewed
May 20, 2025
| // Set length scale to vertical grid if unstable, otherwise the stability adjusted value. | ||
| shoc_mix(k).set(stable_mask, limited_len, dz_zt(k)); | ||
| // Define length scale for stable cells | ||
| const auto length_tmp = ekat::sqrt(0.76*tk(k)/0.1/ekat::sqrt(brunt_tmp + 1.e-10)); |
There was a problem hiding this comment.
Out of curiosity: this should work with sqrt instead of ekat::sqrt right? ADL rule should get it right, no?
There was a problem hiding this comment.
Yes, you are right. I think we have this in many other places too, I will look into creating a PR simplifying some of these calls.
bartgol
approved these changes
May 20, 2025
tcclevenger
added a commit
that referenced
this pull request
May 21, 2025
Fixes FPE introduced in #7188 from temporary values being computed which attempt to take sqrt(some negative value). These values weren't being used, so not an actual bug. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FPE introduced in #7188 from temporary values being computed which attempt to take
sqrt(some negative value). These values weren't being used, so not an actual bug.[BFB]