EAMxx: pass p0 to exner, use it in sc #7411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whannah1
reviewed
Jun 3, 2025
Comment on lines
+492
to
+493
| Sa_ptem(i) = PF::calculate_theta_from_T(s_T_mid_i(num_levs-1), s_p_mid_i(num_levs-1), | ||
| &s_p_int_i(num_levs)); |
There was a problem hiding this comment.
This is the only part I'm confused about. Based on @bogensch 's explanation in the issue I would think the last argument needs to be s_p_mid_i rather than s_p_int_i .
There was a problem hiding this comment.
We can change that too (either works for me); @bogensch who misread your instructions (me or walter)? 😜
There was a problem hiding this comment.
In this case the winner is Naser. We want to override P0 and make it so that P0 is the actual surface pressure, which is represented by the bottom index of s_p_int_i. It looks to my eyes that this was implemented correctly.
|
Closing this pr as it is wrong. Thanks to @oksanaguba for clarification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NBFB]
fixes #7407