EAMxx: Change DPxx large scale subsidence routine to semi Lagrangian formulation (draft) #7413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I presume the issue was related to packs. LinInterp is hard-coding packs as the scalar type. I tried a while ago to make LinInterp work with regular Real types, and I think I made it, but then put the branch on the back burner and forgot about it. Imho, we should revive that effort, as we should not force users to use Pack's just to use LinInterp. That said, one workaround should be to use views of Pack<Real,1>. But maybe you already tried that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the large-scale (LS) subsidence routine used in DPxx, replacing the centered-difference scheme with a semi-Lagrangian approach. This change addresses an issue observed in an edge case with strong LS subsidence, where the original method produced an unstable signature in the water vapor (qv) profile. A comparison plot illustrating this issue—contrasting the control simulation with the new solution implemented in this PR—can be found here: Full diagnostics
The updated code compiles and runs as expected. However, I acknowledge that it likely does not yet conform to EAMxx coding standards. In particular, I implemented a custom inline linear interpolation routine, as I was unable to get EKAT’s interpolation utility to compile properly when interfacing with it. I’m submitting this as a draft PR to request feedback and guidance on making the code PR-ready. Assistance with integrating the EKAT interpolation routine—or any other suggestions for bringing the code up to standard—would be greatly appreciated.