remove code that is not needed anymore in MOAB driver #7437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
number of entities nentities is notused anymore also, we do not need the method seq_map_set_type it is a leftover, not used during mapping anymore
we can pass just the array pointer; no need for (1,1)
rljacob
changed the title
rljacob
added
the
Coupler
vijaysm
approved these changes
Jun 17, 2025
rljacob
added a commit
that referenced
this pull request
Jun 20, 2025
previous simplifications made this code obsolete Also, be more consistent when set/get tag methods are used No need to pass first element, array pointer is simpler [BFB]
rljacob
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous simplifications made this code obsolete
Also, be more consistent when set/get tag methods are used
No need to pass first element, array pointer is simpler