Skip to content

Conversation

whannah1
Copy link
Contributor

This updates the value of potential temperature exported to the surface models to be consistent with how the coupler calculates fluxes.

Fixes #7407

[non-BFB]

@whannah1 whannah1 added bug fix PR non-BFB PR makes roundoff changes to answers. CC PR is climate changing EAMxx Issues related to EAMxx labels Jun 17, 2025
Copy link
Contributor

@tcclevenger tcclevenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to trigger AT

Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💟

@mahf708 mahf708 marked this pull request as draft June 17, 2025 18:29
@mahf708 mahf708 added the CI: approved Allow gh actions PR testing on ghci-snl-* machines label Jun 17, 2025
@mahf708 mahf708 marked this pull request as ready for review June 17, 2025 18:29
Copy link
Contributor

@bogensch bogensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a DPxx case with this branch and everything looks as expected with this modification.

@mahf708
Copy link
Contributor

mahf708 commented Jun 17, 2025

@whannah1 this is good to go in my understanding. I'd push for integrating and blessing asap. Since this is only EAMxx, no need to go through next, but one would need to do blesses pretty quickly.

jgfouca added a commit that referenced this pull request Jun 18, 2025
EAMxx: Fix theta for surface coupling export bug

This updates the value of potential temperature exported to the
surface models to be consistent with how the coupler calculates
fluxes.

Fixes #7407

[non-BFB]
@jgfouca jgfouca merged commit f734bd2 into master Jun 18, 2025
14 of 38 checks passed
@jgfouca jgfouca deleted the whannah/eamxx/fix-theta-cpl-bug-v2 branch June 18, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix PR CC PR is climate changing CI: approved Allow gh actions PR testing on ghci-snl-* machines EAMxx Issues related to EAMxx non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EAMxx: Passing surface coupler inconsistent potential temperature
7 participants