Skip to content

Add support for trigrid Arctic RRM #7442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Add support for trigrid Arctic RRM #7442

merged 1 commit into from
Jun 26, 2025
+41 −7

Conversation

darincomeau
Copy link
Member

@darincomeau darincomeau commented Jun 17, 2025 •
edited by rljacob
Loading

Adds grid alias, domain and mapping files for arcticx4v1pg2_r025_ARRM10to60E2r1 resolution. All support files are staged in public inputdata and world readable.

Adds new default 80 layer ncdata for arcticx4v1pg2 atmosphere mesh (h/t @whannah1 ).

[BFB]
Fixes #7440

@darincomeau darincomeau requested a review from jonbob June 17, 2025 21:03
@darincomeau darincomeau added BFB PR leaves answers BFB Coupled Model RRM Regionally refined model labels Jun 17, 2025
@darincomeau
Copy link
Member Author

Note the existing bigrid arcticx4v1pg2_ARRM10to60E2r1 resolution is incompatible with v3 ELM configuration, hence the need for an updated resolution.

Note the domain.lnd.r025_ARRM10to60E2r1.250617.nc used here was generated such that grid cell areas are not truncated to 3 decimal places.
Waiting on a final SMS.arcticx4v1pg2_r025_ARRM10to60E2r1.WCYCL1850.chrysalis_intel test in the queue with this land domain change.

@rljacob
Copy link
Member

rljacob commented Jun 17, 2025

A test for this should be added to the hi-res suite. Have you tried running it on pm-cpu? That's where we run the hi-res suite.

@jonbob
Copy link
Contributor

jonbob commented Jun 17, 2025

@rljacob -- this configuration is more for HiLat than e3sm. Do you still want us to add a test?

@darincomeau
Copy link
Member Author

Passes

  • SMS.arcticx4v1pg2_r025_ARRM10to60E2r1.WCYCL1850.chrysalis_intel
  • SMS.arcticx4v1pg2_r025_ARRM10to60E2r1.WCYCL1850.pm-cpu_intel

@rljacob
Copy link
Member

rljacob commented Jun 18, 2025

Ok hold off for now on adding a test.

milenaveneziani
milenaveneziani approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@milenaveneziani milenaveneziani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on visual inspection

@milenaveneziani milenaveneziani mentioned this pull request Jun 21, 2025
Merged
jonbob
jonbob approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on visual inspection and testing

jonbob added a commit that referenced this pull request Jun 25, 2025
@jonbob
Merge branch 'darincomeau/grids/add-trigrid-arrm-support' into next (PR
5cc98cf 
#7442)

Add support for trigrid Arctic RRM

Adds grid alias, domain and mapping files for
arcticx4v1pg2_r025_ARRM10to60E2r1 resolution. All support files are
staged in public inputdata and world readable.

Adds new default 80 layer ncdata for arcticx4v1pg2 atmosphere mesh
(h/t @whannah1 ).

Fixes #7440
[BFB]
@jonbob
Copy link
Contributor

jonbob commented Jun 25, 2025

Passes sanity testing, successfully created SMS.arcticx4v1pg2_r025_ARRM10to60E2r1.WCYCL1850.chrysalis_intel. I also verified that all new files were staged in the inputdata repo

merged to next

@jonbob jonbob merged commit d7a84ce into E3SM-Project:master Jun 26, 2025
7 checks passed
@jonbob
Copy link
Contributor

jonbob commented Jun 26, 2025

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milenaveneziani milenaveneziani milenaveneziani approved these changes

@jonbob jonbob jonbob approved these changes

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB bug fix PR Coupled Model RRM Regionally refined model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arcticx4v1pg2 RRM grid broken, cannot find ncdata
4 participants
@darincomeau @rljacob @jonbob @milenaveneziani