Fix SROF case for MOAB coupler #7444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rof_present is false, river fluxes sent to land need to be set to zero. These tags are still defined and they get added in lnd_import.
Add comments to the complicated if logic in prep_lnd_init
rljacob
added
Coupler
rljacob
commented
Jun 18, 2025
|
tested ne256 coupled model on aurora |
iulian787
approved these changes
Jun 19, 2025
|
bugbot run |
rljacob
added a commit
that referenced
this pull request
Jun 26, 2025
When rof_present is false, as in a case with SROF, be sure to zero out the river fluxes sent to the land model. These tags are still present and acted on by the land model. Also only add them in ocean merge if rof_c2_ocn is true. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rof_present is false, as in a case with SROF, be sure to zero out the river fluxes sent to the land model.
These tags are still present and acted on by the land model. Also only add them in ocean merge if rof_c2_ocn is true.
[BFB]