Skip to content

EAMxx: compute shoc_cond and shoc_evap before ql update #7450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

EAMxx: compute shoc_cond and shoc_evap before ql update #7450

merged 1 commit into from
Jun 19, 2025

Conversation

hassanbeydoun
Copy link
Contributor

@hassanbeydoun hassanbeydoun commented Jun 18, 2025 •
edited by mahf708
Loading

Fixes #7448

[BFB]

@hassanbeydoun hassanbeydoun requested a review from mahf708 June 18, 2025 22:00
@mahf708 mahf708 changed the title Compute shoc_cond and shoc_evap before ql update EAMxx: compute shoc_cond and shoc_evap before ql update Jun 19, 2025
@mahf708 mahf708 added the CI: approved Allow gh actions PR testing on ghci-snl-* machines label Jun 19, 2025
mahf708
mahf708 approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@mahf708 mahf708 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💟

assigning to Jim as well in case he sees this PR before Conrad, so that it gets merged asap.

@mahf708 mahf708 added the BFB PR leaves answers BFB label Jun 19, 2025
@mahf708 mahf708 marked this pull request as draft June 19, 2025 04:14
@mahf708 mahf708 marked this pull request as ready for review June 19, 2025 04:14
@jgfouca
Copy link
Member

jgfouca commented Jun 19, 2025

I assume the DIFFs in the CI are expected, merging.

jgfouca added a commit that referenced this pull request Jun 19, 2025
@jgfouca
Merge branch 'beydoun/fix_cond_tend' into next (PR #7450)
b6121bf 
EAMxx: compute shoc_cond and shoc_evap before ql update

Fixes #7448

[BFB]
@jgfouca jgfouca merged commit 8d6a53d into master Jun 19, 2025
14 of 31 checks passed
@jgfouca jgfouca deleted the beydoun/fix_cond_tend branch June 19, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahf708 mahf708 mahf708 approved these changes

Assignees

@jgfouca jgfouca

@tcclevenger tcclevenger

Labels
BFB PR leaves answers BFB bug fix PR bug CI: approved Allow gh actions PR testing on ghci-snl-* machines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EAMxx: order of cond/evap diags in shoc should be fixed
4 participants
@hassanbeydoun @jgfouca @mahf708 @tcclevenger