Skip to content

Conversation

overfelt
Copy link
Contributor

@overfelt overfelt commented Jun 24, 2025

sol_factb_below_cloud -below-cloud scavenging fraction is basically a tuning factor.
sol_facti_cloud_borne - in-cloud scavenging fraction has a physical basis and reflects activation fraction.
sol_factic_cloud_borne - in-cloud convective scavenging fraction has a physical basis and reflects activation fraction
f_act_conv_below_cloud - convection activation fraction.

The defaults are the same as have always been used so this is a BFB change:

[BFB]

@overfelt overfelt changed the title User control over the are four factors that control in clound and below cloud activation. WIP: User control over the are four factors that control in clound and below cloud activation. Jun 24, 2025
@overfelt overfelt changed the title WIP: User control over the are four factors that control in clound and below cloud activation. WIP: User control over the are four factors that control in cloud and below cloud activation. Jun 24, 2025
@overfelt overfelt changed the title WIP: User control over the are four factors that control in cloud and below cloud activation. WIP: EAMXX: User control over the are four factors that control in cloud and below cloud activation. Jun 24, 2025
@rljacob rljacob requested a review from mahf708 June 26, 2025 01:57
@rljacob rljacob added the EAMxx Issues related to EAMxx label Jun 26, 2025
Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete, gotta add those new params in the xml file under the appropriate process

@overfelt overfelt closed this Jun 28, 2025
@overfelt overfelt reopened this Jun 28, 2025
@overfelt overfelt force-pushed the overfelt/eamxx/make_activation_fractions_input_values branch from 8c3c0b1 to 2bf03b1 Compare June 28, 2025 15:26
@overfelt overfelt closed this Jun 28, 2025
@overfelt overfelt reopened this Jun 28, 2025
@overfelt overfelt changed the title WIP: EAMXX: User control over the are four factors that control in cloud and below cloud activation. EAMXX: User control over the are four factors that control in cloud and below cloud activation. Jun 28, 2025
@mahf708
Copy link
Contributor

mahf708 commented Jun 28, 2025

@overfelt how do you feel about adding better names for the user-facing tuning knobs? Something clearer than the sol f act etc?

@overfelt
Copy link
Contributor Author

I asked @singhbalwinder to come up with better names. It is further complicated as these are not directly used, but inputs to the function that calculates the factors.

@kaizhangpnl kaizhangpnl added the MAM4xx MAM4xx related changes label Jul 16, 2025
@rljacob
Copy link
Member

rljacob commented Jul 24, 2025

waiting on changes from @singhbalwinder

@rljacob
Copy link
Member

rljacob commented Aug 14, 2025

@singhbalwinder this needs your attention.

@singhbalwinder
Copy link
Contributor

@overfelt : Could you please use the following variable names (suggested by @kaizhangpnl ):

1. sol_factb_below_cloud (new name: scav_fraction_below_cloud_strat): below-cloud scavenging fraction is basically a tuning factor.
 
2. sol_facti_cloud_borne (new name: scav_fraction_in_cloud_strat): in-cloud scavenging fraction has a physical basis and reflects activation fraction.

3. sol_factic_cloud_borne (new name: scav_fraction_in_cloud_conv): in-cloud convective scavenging fraction has a physical basis and reflects activation fraction

4. f_act_conv_below_cloud (new name: activation_fraction_in_cloud_conv) : convection activation fraction.

@overfelt overfelt force-pushed the overfelt/eamxx/make_activation_fractions_input_values branch from 2bf03b1 to 71274ed Compare September 22, 2025 21:12
@overfelt overfelt force-pushed the overfelt/eamxx/make_activation_fractions_input_values branch from 6e9a801 to 5cbc044 Compare September 25, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAMxx Issues related to EAMxx MAM4xx MAM4xx related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants