Set default value of fminval in python version of gen_domain to 1.0e-08 #7466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbob
added
bug fix PR
non-BFB
|
@rljacob -- I've asked you to review this as well. It mostly impacts the coupled model, so please assign anyone else you think might be interested. And let me know if we should try to get the same change made in the cime Fortran version of this code. |
|
Do we still use the Fortran version at all? @whannah1 or @bishtgautam ? |
rljacob
approved these changes
Jul 16, 2025
|
It gets built by e3sm-unified. I think I make most of the domain files currently, but we could also change any documentation to point at this version. Either that or make sure any documentation specifies fminval on the command line of the Fortran version |
|
@rljacob, I don't generate domain files for supported resolutions. So, I'm unable to answer your question. |
proteanplanet
approved these changes
Jul 16, 2025
jonbob
added a commit
that referenced
this pull request
Jul 17, 2025
) Set default value of fminval in python version of gen_domain to 1.0e-08 The current version of gen_domain has a default value of 0.001 for the min allowable land fraction. That is too large and shows up in the cpl area budget for e3sm runs. The fminval can be overwritten on the command line but rarely is, so it seems safer to make the default much smaller (1e-8) instead. The resulting domain files will have a different number of lnd cells, so it would be complicated to regenerate domain files for all supported mesh configurations. But at least any new domain files should be corrected. Partially fixes #7465 -- the Fortran version in CIME also has the same issue [non-BFB] for any new domain files
|
merged to next |
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of gen_domain has a default value of 0.001 for the min allowable land fraction. That is too large and shows up in the cpl area budget for e3sm runs. The fminval can be overwritten on the command line but rarely is, so it seems safer to make the default much smaller (1e-8) instead. The resulting domain files will have a different number of lnd cells, so it would be complicated to regenerate domain files for all supported mesh configurations. But at least any new domain files should be corrected.
Partially fixes #7465 -- the Fortran version in CIME also has the same issue
[non-BFB] for any new domain files