Skip to content

Conversation

overfelt
Copy link
Contributor

@overfelt overfelt commented Jun 27, 2025

The column integrated modal values of the deposition flux of
aqueous SO4 and the deposition flux of aqueous H2SO4 were
always added to the Field Manager (FM) to be available for the
output. This PR hides these diagnostics under a flag.
Since EAMxx doesn't output any fields by default, this change
will be BFB.

[BFB]

@overfelt overfelt changed the title There are two diagnostic output fields that should be optional. WIP: There are two diagnostic output fields that should be optional. Jun 27, 2025
@overfelt overfelt closed this Jun 28, 2025
@overfelt overfelt reopened this Jun 28, 2025
@overfelt overfelt force-pushed the overfelt/eamxx/make_output_SO4_and_H2SO4_diagnostics_optional branch from 6991bde to 2771f50 Compare June 30, 2025 18:27
@overfelt overfelt closed this Jun 30, 2025
@overfelt overfelt reopened this Jun 30, 2025
@overfelt overfelt closed this Jul 1, 2025
@overfelt overfelt reopened this Jul 1, 2025
@overfelt overfelt changed the title WIP: There are two diagnostic output fields that should be optional. Move dqdt_so4_aqueous_chemistry and dqdt_h2so4_uptake to the standard mam4xx diagnostic struct. Jul 18, 2025
@overfelt overfelt force-pushed the overfelt/eamxx/make_output_SO4_and_H2SO4_diagnostics_optional branch from a038a89 to 55c11fa Compare July 18, 2025 20:28
@overfelt overfelt requested a review from singhbalwinder July 18, 2025 20:29
Copy link
Contributor

@singhbalwinder singhbalwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, James!

@singhbalwinder
Copy link
Contributor

@mahf708: Are you okay with these diagnostic names? We plan on removing them in the future, as we may be able to compute these using utilities for reduction.

@mahf708
Copy link
Contributor

mahf708 commented Jul 18, 2025

    // Register computed diagnostic fields
    add_field<Computed>("dqdt_so4_aqueous_chemistry", vector2d_nmodes, kg/m2/s,  grid_name);
    add_field<Computed>("dqdt_h2so4_uptake", vector2d_nmodes, kg/m2/s,  grid_name);

    // Diagnostics: tendencies due to gas phase chemistry [mixed units: kg/kg/s or #/kg/s]
    add_field<Computed>("mam4_microphysics_tendency_gas_phase_chemistry", vector3d_num_gas_aerosol_constituents, nondim, grid_name);

    // Diagnostics: tendencies due to aqueous chemistry [mixed units: kg/kg/s or #/kg/s]
    add_field<Computed>("mam4_microphysics_tendency_aqueous_chemistry", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
    // Diagnostics: SO4 in-cloud tendencies [mixed units: kg/kg/s or #/kg/s]
    add_field<Computed>("mam4_microphysics_tendency_aqso4", vector3d_mid_nmodes, nondim, grid_name);
    // Diagnostics: H2SO4 in-cloud tendencies [mixed units: kg/kg/s or #/kg/s]
    add_field<Computed>("mam4_microphysics_tendency_aqh2so4", vector3d_mid_nmodes, nondim, grid_name);
    // Diagnostics: tendencies due to aerosol microphysics (gas aerosol exchange) [mixed units: mol/mol/s or #/mol/s]
    add_field<Computed>("mam4_microphysics_tendency_condensation", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
    add_field<Computed>("mam4_microphysics_tendency_renaming", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
    add_field<Computed>("mam4_microphysics_tendency_nucleation", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
    add_field<Computed>("mam4_microphysics_tendency_coagulation", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
    add_field<Computed>("mam4_microphysics_tendency_renaming_cloud_borne", vector3d_num_gas_aerosol_constituents, nondim, grid_name);

How are these terms different from the ones below them with "mam4_microphysics_tendency"?

Oh, these are just vertically reduced? If so, I would make the note of that in the name along with the mam4_microphysics_tendency part. But it's ok if you prefer to skip the naming for now (and revisit later).

Copy link
Contributor

@mjschmidt271 mjschmidt271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be low-impact, and looks good to me!

@singhbalwinder singhbalwinder self-assigned this Jul 21, 2025
@singhbalwinder singhbalwinder added BFB PR leaves answers BFB EAMxx Issues related to EAMxx MAM4xx MAM4xx related changes labels Jul 21, 2025
@overfelt overfelt force-pushed the overfelt/eamxx/make_output_SO4_and_H2SO4_diagnostics_optional branch from 931932a to 217224b Compare July 21, 2025 22:06
@singhbalwinder
Copy link
Contributor

@overfelt: I think this branch is not pointing to the MAM4xx submodule's main branch. Could you please update it to point it to MAM4xx's main branch? Thanks!

@overfelt overfelt force-pushed the overfelt/eamxx/make_output_SO4_and_H2SO4_diagnostics_optional branch from 217224b to 03d8c09 Compare July 23, 2025 12:56
singhbalwinder added a commit that referenced this pull request Jul 23, 2025
…tional' into next (PR #7469)

Move dqdt_so4_aqueous_chemistry and dqdt_h2so4_uptake to the standard mam4xx diagnostic struct

The column integrated modal values of the deposition flux of
aqueous SO4 and the deposition flux of aqueous H2SO4 were
always added to the Field Manager (FM) to be available for the
output. This PR hides these diagnostics under a flag.
Since EAMxx doesn't output any fields by default, this change
will be BFB.

[BFB]

* overfelt/eamxx/make_output_SO4_and_H2SO4_diagnostics_optional:
  Update mam4xx to point to main.
  Add note that these fields are vertically reduced
  Move dqdt_so4_aqueous_chemistry and dqdt_h2so4_uptake to the standard mam4xx diagnostic struct.
@singhbalwinder singhbalwinder merged commit 4e14a9b into master Jul 23, 2025
18 checks passed
@singhbalwinder singhbalwinder deleted the overfelt/eamxx/make_output_SO4_and_H2SO4_diagnostics_optional branch July 23, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB EAMxx Issues related to EAMxx MAM4xx MAM4xx related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants