-
Notifications
You must be signed in to change notification settings - Fork 435
Move dqdt_so4_aqueous_chemistry and dqdt_h2so4_uptake to the standard mam4xx diagnostic struct. #7469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dqdt_so4_aqueous_chemistry and dqdt_h2so4_uptake to the standard mam4xx diagnostic struct. #7469
Conversation
6991bde
to
2771f50
Compare
a038a89
to
55c11fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, James!
@mahf708: Are you okay with these diagnostic names? We plan on removing them in the future, as we may be able to compute these using utilities for reduction. |
// Register computed diagnostic fields
add_field<Computed>("dqdt_so4_aqueous_chemistry", vector2d_nmodes, kg/m2/s, grid_name);
add_field<Computed>("dqdt_h2so4_uptake", vector2d_nmodes, kg/m2/s, grid_name);
// Diagnostics: tendencies due to gas phase chemistry [mixed units: kg/kg/s or #/kg/s]
add_field<Computed>("mam4_microphysics_tendency_gas_phase_chemistry", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
// Diagnostics: tendencies due to aqueous chemistry [mixed units: kg/kg/s or #/kg/s]
add_field<Computed>("mam4_microphysics_tendency_aqueous_chemistry", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
// Diagnostics: SO4 in-cloud tendencies [mixed units: kg/kg/s or #/kg/s]
add_field<Computed>("mam4_microphysics_tendency_aqso4", vector3d_mid_nmodes, nondim, grid_name);
// Diagnostics: H2SO4 in-cloud tendencies [mixed units: kg/kg/s or #/kg/s]
add_field<Computed>("mam4_microphysics_tendency_aqh2so4", vector3d_mid_nmodes, nondim, grid_name);
// Diagnostics: tendencies due to aerosol microphysics (gas aerosol exchange) [mixed units: mol/mol/s or #/mol/s]
add_field<Computed>("mam4_microphysics_tendency_condensation", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
add_field<Computed>("mam4_microphysics_tendency_renaming", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
add_field<Computed>("mam4_microphysics_tendency_nucleation", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
add_field<Computed>("mam4_microphysics_tendency_coagulation", vector3d_num_gas_aerosol_constituents, nondim, grid_name);
add_field<Computed>("mam4_microphysics_tendency_renaming_cloud_borne", vector3d_num_gas_aerosol_constituents, nondim, grid_name); How are these terms different from the ones below them with "mam4_microphysics_tendency"? Oh, these are just vertically reduced? If so, I would make the note of that in the name along with the mam4_microphysics_tendency part. But it's ok if you prefer to skip the naming for now (and revisit later). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be low-impact, and looks good to me!
931932a
to
217224b
Compare
@overfelt: I think this branch is not pointing to the MAM4xx submodule's main branch. Could you please update it to point it to MAM4xx's main branch? Thanks! |
217224b
to
03d8c09
Compare
…tional' into next (PR #7469) Move dqdt_so4_aqueous_chemistry and dqdt_h2so4_uptake to the standard mam4xx diagnostic struct The column integrated modal values of the deposition flux of aqueous SO4 and the deposition flux of aqueous H2SO4 were always added to the Field Manager (FM) to be available for the output. This PR hides these diagnostics under a flag. Since EAMxx doesn't output any fields by default, this change will be BFB. [BFB] * overfelt/eamxx/make_output_SO4_and_H2SO4_diagnostics_optional: Update mam4xx to point to main. Add note that these fields are vertically reduced Move dqdt_so4_aqueous_chemistry and dqdt_h2so4_uptake to the standard mam4xx diagnostic struct.
The column integrated modal values of the deposition flux of
aqueous SO4 and the deposition flux of aqueous H2SO4 were
always added to the Field Manager (FM) to be available for the
output. This PR hides these diagnostics under a flag.
Since EAMxx doesn't output any fields by default, this change
will be BFB.
[BFB]