Skip to content

Clarify registry descriptions for avgSurface* variables #7472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
Merged

Clarify registry descriptions for avgSurface* variables #7472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2ba718
Clarify registry descriptions for avgSurface* variables: ...
cbegeman Jun 25, 2025
be96654
update inline comment about surface tracer values
cbegeman Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions components/mpas-ocean/src/Registry.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3958,18 +3958,18 @@
/>
<var_array name="avgTracersSurfaceValue" type="real" dimensions="nCells Time" packages="forwardMode;analysisMode">
<var name="avgTemperatureSurfaceValue" array_group="surfaceValues" units="C"
description="Time averaged potential temperature extrapolated to ocean surface"
description="Time averaged potential temperature in the uppermost active level as determined by minLevelCell"
/>
<var name="avgSalinitySurfaceValue" array_group="surfaceValues" units="1.e-3"
description="Time averaged salinity extrapolated to ocean surface"
description="Time averaged salinity in the uppermost active level as determined by minLevelCell"
/>
</var_array>
<var_array name="avgSurfaceVelocity" type="real" dimensions="nCells Time" packages="forwardMode;analysisMode">
<var name="avgSurfaceVelocityZonal" array_group="vel_zonal" units="m s^-1"
description="Time averaged zonal surface velocity"
description="Time averaged zonal surface velocity located in minLevelCell"
/>
<var name="avgSurfaceVelocityMeridional" array_group="vel_meridional" units="m s^-1"
description="Time averaged meridional surface velocity"
description="Time averaged meridional surface velocity located in minLevelCell"
/>
</var_array>
<var_array name="avgSSHGradient" type="real" dimensions="nCells Time" packages="forwardMode;analysisMode">
Expand Down
6 changes: 3 additions & 3 deletions components/mpas-ocean/src/shared/mpas_ocn_diagnostics.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,9 @@ subroutine ocn_diagnostic_solve(dt, statePool, forcingPool, meshPool, verticalMe

!
! extrapolate tracer values to ocean surface
! this eventually be a modelled process
! at present, just copy k=1 tracer values onto surface values
! field will be updated below is better approximations are available
! this eventually could be a modelled process
! at present, just copy minLevelCell tracer values onto surface values
! field will be updated below as better approximations are available

!TDR need to consider how to handle tracersSurfaceValues
#ifdef MPAS_OPENACC
Expand Down