make mct and moab differences zero in combo-driver. #7476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the correction factors to see if we obtain 0 differences we do not, at step 5, we still have differences Is that the frst time ocean couples with atm ? those are not minor differences ocn run(seq_comm_compare_mb_mct) , difference on tag Sa_pbot^@ = 6.3068705975487666E-002
it has _src_ in name, it shows the source values before sending it is of little value, the receive should be enough (and correct) unless there is a catastrophic failure
correction factors method not onlly computes the correction factors (aream/area or area/aream), but it also factors the fluxes existent on the component side, with the correction factors (flux <- flux * mdl2drv) Then, it sends all fields to coupler , after scaling just the initial fluxes It seems that only Fioo_q on ocean is affected in simple coupled ne4 case (all other fluxes are 0 ?) need to double check also, put factor in second term of multiplication before, we were doing flux <- mdl2drv * flux
so to compare mct and moab for correction factors, put the factor at the end of flux <- flux * factor (before it was flux <- factor * flux)
this is just to compare with ocn mct instance we use MOAB tools, but it should not matter
rljacob
added
Coupler
rljacob
changed the title
vijaysm
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy correction factors from mct to moab which eliminates differences
between the two within the combined coupler in driver-moab (when reading maps).
Ignore for the time being the correction factors computed by moab.
Also add and remove a mesh write in MOABDEBUG.