EAMxx dycore defaults should match EAMv3 defaults #7483
Conversation
|
What does "[CC]" mean? I'm guessing the ne4 DIFFs are expected. Out tomorrow, but I can merge this first thing monday. |
|
@mt5555 - Thanks for catching this. I agree that making them consistent with all other resolutions makes sense. We wouldn't expect this change to make the ne4 tests fail, would we? |
|
@tcclevenger - CC would mean Climate Changing as you'd indicated - so answer changing for the EAMxx ne4 (and ne120 if we're running ne120 tests), not just non-BFB. |
|
@crterai : These settings are quite robust and well tested (i.e. used by EAM at ne4), so I'm assuming all the ne4 EAMxx tests will run, but DIFF. So unfortunately a lot of dashboard failures requiring new baselines. @tcclevenger : so not a high priority, we could wait until there is a lull in more critical EAMxx PRs. |
| <hv_ref_profiles>6</hv_ref_profiles> <!-- Default (rough topography) --> | ||
| <hv_ref_profiles hgrid="ne4np4">0</hv_ref_profiles> <!-- Value for smooth topography/aquaplanet --> | ||
| <hv_ref_profiles hgrid="ne120np4">0</hv_ref_profiles> | ||
| <hv_ref_profiles hgrid="ne512np4">0</hv_ref_profiles> |
There was a problem hiding this comment.
won't these edits change answers for ne120 and ne512?
There was a problem hiding this comment.
yes, that's expected, and is why this PR has a [CC] tag
|
FYI to @jgfouca, @bartgol, @AaronDonahue, @singhbalwinder about this change affecting the ne4 tests on the dashboard. |
|
note: should go in with #7249 |
tcclevenger
force-pushed
the
eamxx-topo-defaults
branch
from
2f2c850 to
fc6e494
Compare
[BFB] for most resolutions (NE30, NE256, NE1024), may be CC for some tests
|
Will let testing rerun, and then merge this if there are no objections. We can handle #7249 separately. |
|
Would this change values here? |
Yes, |
|
Since I'm out tomorrow, I'll merge Monday (or sunday night) in case the dashboard needs attention |
EAMxx has funky resolution-specific settings for pgrad_correction and hv_ref_profiles [BFB] for most resolutions (NE30, NE256, NE1024) [CC] for some tests, like ne4. Also NE120, NE512 cases.
|
@ndkeen Would you like me to update https://e3sm.atlassian.net/wiki/spaces/DOC/pages/5105156097/EAMxx+Resolutions+Common+Terms+F2010-SCREAMv1? NDK: Sure go ahead. And feel free to make the table/page more useful to wider audience. I was just trying to keep it straight in my own head. |
EAMxx has funky resolution-specific settings for pgrad_correction and hv_ref_profiles
[BFB] for most resolutions (NE30, NE256, NE1024)
[CC] for some tests, like ne4. Also NE120, NE512 cases.