EAMxx: add test for hremap nudging #7497
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
components/eamxx/cime_config/testdefs/testmods_dirs/eamxx/hremap_nudged/shell_commands
Outdated
Show resolved
Hide resolved
|
|
||
| $atmchange -b physics::atm_procs_list+="nudging" | ||
|
|
||
| $atmchange -b nudging::nudging_filenames_patterns="${input_data_dir}/atm/scream/hremap_nudging/output*.nc" |
There was a problem hiding this comment.
file="true" in the XML for this parameter. However, since you are using a glob here instead of a file name, I'm not sure it will work.
There was a problem hiding this comment.
@mahf708 , are you talking about the nudging_filenames_patterns parameter or nudging_refine_remap_mapfile?
There was a problem hiding this comment.
nudging_filenames_patterns
There was a problem hiding this comment.
@mahf708 @jgfouca did we decide what to do with this issue? Are we simply going to require that users manually download the files beforehand? Or do we want to add logic to our buildnml? I can work on the latter, and may be able to cook up a solution in a day or so, but I wonder if it's too niche of a case to justify adding complexity to our toolchain...
There was a problem hiding this comment.
I am leaning towards basically enabling this test as-is (see https://github.com/E3SM-Project/E3SM/pull/7497/files#diff-e2fbf220fd98012c3bdf61d7f341a1815f43823af2ffd3bf926d5aafc4363d8bR762), then it will fail on most machines, and we [people who have access to machines and do blessing, etc. regularly] will manually transfer the files. Then, the tests will pass and we likely won't need to update this test for ~years.
Alternatively, we can just not add the test.
There was a problem hiding this comment.
In other words, my vote is to avoid complicating our toolchain
There was a problem hiding this comment.
Sounds good. Are you ok taking care of moving the files around for the nightly testing machines once the PR is merged?
There was a problem hiding this comment.
Yes, but I may need to ask you/Jim for the SNL machines if that's ok :)
mahf708
force-pushed
the
mahf708/eamxx/horiz-remap-nudging-test
branch
from
c900c71 to
7cd2a36
Compare
|
@AaronDonahue, pls tag me in your cdash updates if issues emerge from this test mod (hremap_nudged). We will need to do a fair bit of manual data shuffling, which I will do once we get some fails (let's think of it as a blessing exercise for me) |
…7497) adding a new test to cover hremap nudging in EAMxx. [BFB]
adding a new test to cover hremap nudging in EAMxx.