-
Notifications
You must be signed in to change notification settings - Fork 435
EAMxx: add test for hremap nudging #7497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
components/eamxx/cime_config/testdefs/testmods_dirs/eamxx/hremap_nudged/shell_commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #!/bin/bash | ||
|
|
||
| cime_root=$(./xmlquery --value CIMEROOT) | ||
| input_data_dir=$(./xmlquery --value DIN_LOC_ROOT) | ||
| atmchange=$cime_root/../components/eamxx/scripts/atmchange | ||
| case_name=$(./xmlquery --value CASE) | ||
|
|
||
| $atmchange -b physics::atm_procs_list+="nudging" | ||
|
|
||
| $atmchange -b nudging::nudging_filenames_patterns="${input_data_dir}/atm/scream/hremap_nudging/output*.nc" | ||
| $atmchange -b nudging::source_pressure_type=TIME_DEPENDENT_3D_PROFILE | ||
| $atmchange -b nudging::nudging_fields=U,V | ||
| $atmchange -b nudging::nudging_timescale=21600 | ||
| $atmchange -b nudging::nudging_refine_remap_mapfile="${input_data_dir}/atm/scream/maps/map_ne4pg2_to_ne30pg2_nco_c20241108.nc" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgfouca @bartgol how to ensure this data gets downloaded from the server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file="true"in the XML for this parameter. However, since you are using a glob here instead of a file name, I'm not sure it will work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahf708 , are you talking about the
nudging_filenames_patternsparameter ornudging_refine_remap_mapfile?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nudging_filenames_patterns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahf708 @jgfouca did we decide what to do with this issue? Are we simply going to require that users manually download the files beforehand? Or do we want to add logic to our buildnml? I can work on the latter, and may be able to cook up a solution in a day or so, but I wonder if it's too niche of a case to justify adding complexity to our toolchain...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am leaning towards basically enabling this test as-is (see https://github.com/E3SM-Project/E3SM/pull/7497/files#diff-e2fbf220fd98012c3bdf61d7f341a1815f43823af2ffd3bf926d5aafc4363d8bR762), then it will fail on most machines, and we [people who have access to machines and do blessing, etc. regularly] will manually transfer the files. Then, the tests will pass and we likely won't need to update this test for ~years.
Alternatively, we can just not add the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other words, my vote is to avoid complicating our toolchain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Are you ok taking care of moving the files around for the nightly testing machines once the PR is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I may need to ask you/Jim for the SNL machines if that's ok :)