Skip to content

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Jul 14, 2025

Ensures the diag name matches what was requested.

[BFB]

In current master, requesting something like nccn_vert_avg_horiz_avg gave the error Error! Field nccn_vert_avg on grid physics not found., since the actual field stored after the vert avg was nccnavg_none, making piping the VertContractionDiag hard.

@bartgol bartgol requested a review from mahf708 July 14, 2025 19:59
@bartgol bartgol self-assigned this Jul 14, 2025
@bartgol bartgol added bug fix PR BFB PR leaves answers BFB EAMxx Issues related to EAMxx labels Jul 14, 2025
Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see

@mahf708
Copy link
Contributor

mahf708 commented Jul 14, 2025

#7507

@bartgol bartgol closed this Jul 14, 2025
@bartgol bartgol deleted the bartgol/eamxx/vert-contraction-diag-fix branch September 16, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB bug fix PR EAMxx Issues related to EAMxx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants