EAMxx: fix bug in physics unit tests baselines handling #7524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Must allow for pointers to non-const data as well
bartgol
added
bug fix PR
BFB
bartgol
commented
Jul 16, 2025
|
|
||
| template <typename T, typename I> | ||
| std::enable_if_t<std::is_integral<I>::value> | ||
| write_scalars(std::ofstream& ofile, const T* const data, I N) { |
There was a problem hiding this comment.
The const was preventing the compile to pick this overload for a T=double*. Instead, it picked the variadic template overload below, effectively writing a pointer and an int, rather than an array of T.
The const is also not needed, as the new signature covers it with T=const double.
jgfouca
approved these changes
Jul 16, 2025
|
The standalone failures are expected (we need to merge the PR and regenerate baselines), while the v1 failures are likely due to #7412 that was merged yesterday. I fired the baseline regen job for v1 tests, and I will re-run the v1 tests for this PR, just to be sure. If all is good, I will merge. |
bartgol
added a commit
that referenced
this pull request
Jul 16, 2025
…(PR #7524) Fix a template overload resolution. Also, add possibility to generate ASCII baselines (for debug purposes only). [BFB]
bartgol
added a commit
that referenced
this pull request
Jul 17, 2025
Similar to p3_run_and_cmp as done in #7524 [BFB]
bartgol
added a commit
that referenced
this pull request
Jul 17, 2025
Similar to p3_run_and_cmp as done in #7524 [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a template overload resolution. Also, add possibility to generate ASCII baselines (for debug purposes only).
[BFB]
Note: the ASCII baselines are NOT to be used for baselines comparison, as we inevitably truncate periodic numbers, causing diffs when they are re-read in. They are just meant to be used for visually inspecting the baselines. For instance, it allowed me to see that one entry was in hex format rather than an integer, which allowed me to spot a bug (where a pointer instead of the pointed value was written).