EAMxx: make horiz interp remappers (coarsening and refining) handle fields without COL tag #7526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
added
bug fix PR
BFB
bartgol
force-pushed
the
bartgol/eamxx/horiz-remap-upgrade
branch
from
d4a1ee4 to
15ea078
Compare
mahf708
approved these changes
Jul 17, 2025
bartgol
added a commit
that referenced
this pull request
Jul 17, 2025
Allows IO to have fields without COL dim in a stream that uses hremap. This makes hremap more aligned with what vremap already did. [BFB]
bartgol
added a commit
that referenced
this pull request
Jul 21, 2025
The bug was added in #7526. While the PR did simplify the geo data remapping registration phase, it missed an important step: adding the remapped geo data field in the tgt grid. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows IO to have fields without COL dim in a stream that uses hremap.
This makes hremap more aligned with what vremap already did.
[BFB]
Fixes #7521.
I ran cld_fraction_standalone with hremap (ne4->ne2) outputing
qi_at_model_top_horiz_avgand verified that a) the bug was reproducible, and b) this PR fixes it. I also added a vertical profile field to both coarsening/refining remap unit tests.