Skip to content

Cleanup to OCN/GLC TF-coupling #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

Cleanup to OCN/GLC TF-coupling #7529

merged 2 commits into from
Jul 30, 2025

Conversation

matthewhoffman
Copy link
Contributor

@matthewhoffman matthewhoffman commented Jul 17, 2025 •
edited by jonbob
Loading

This branch addresses a few details to get production simulations using TF coupling ready:

  1. Adjustments to MALI hist fields to make output volume more manageable in multiyear runs
  2. Add grid-dependent parameter files for TF-coupling. For TF-coupling to be used to generate melt rates using the ISMIP6/Jourdain ice-shelf basal melting parameterization in MALI, MALI requires a parameter file that includes the gamma0 melt sensitivity parameter, the ice-shelf region masks (different than the regional stats mask), and an optional ocean temperature bias correction field. Such files have been added to the input data repo and added to the MALI streams.landice file for the two Antarctic Ice Sheet meshes when appropriate conditions are met.

[non-BFB] only for ais configurations with MALI and MPAS-O

@matthewhoffman matthewhoffman requested a review from trhille July 17, 2025 22:02
@matthewhoffman matthewhoffman changed the title Change default gamma0 to standard value Cleanup to OCN/GLC TF-coupling Jul 17, 2025
@matthewhoffman
Copy link
Contributor Author

Testing

  • ERS_D_Ld5.TL319_oQU240wLI_ais8to30.MPAS_FOLISIO_JRA1p5: PASSED, and I confirmed totalFloatingBasalMassBal is nonzero
  • ERS_D_Ld5.TL319_IcoswISC30E3r5_ais4to20.GMPAS-JRA1p5-DIB-TFISMF-MALI: PASSED, and I confirmed totalFloatingBasalMassBal is nonzero

@matthewhoffman
Copy link
Contributor Author

Melt rate field (floatingBasalMassBalApplied/-910*3.15e7) from TL319_IcoswISC30E3r5_ais4to20.GMPAS-JRA1p5-DIB-TFISMF-MALI.

Note this is without a deltaT adjustment so includes MPAS-Ocean temperature biases for this configuration.

image

trhille
trhille approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@trhille trhille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @matthewhoffman's testing, this is clearly working as intended.

irenavankova
irenavankova approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@irenavankova irenavankova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on visual inspection.

@jonbob
Copy link
Contributor

jonbob commented Jul 23, 2025

@matthewhoffman -- do we want to add a test with the new compset to the landice_developer suite as part of this PR?

@matthewhoffman
Copy link
Contributor Author

@jonbob , yes, that seems like a good idea. I'm traveling today, but can address that after I return. Or you're welcome to take care of it if that is more convenient timing.

@matthewhoffman
Copy link
Contributor Author

@jonbob , I realized there is another input file needed for functionality in this PR so it will need some adjustments yet. I will add the test once that is ready.

@matthewhoffman matthewhoffman force-pushed the matthewhoffman/mali/gamma0-default branch from cfed445 to 363381f Compare July 24, 2025 22:45
@matthewhoffman
Copy link
Contributor Author

Note: I force-pushed to:

  1. avoid a merge conflict with recently merged Add MALI regional stats history files #7528
  2. remove the commit that changed the gamma0 default. That implementation has been replaced by 363381f

@matthewhoffman
Copy link
Contributor Author

Testing (updated)

./create_test --wait --walltime 0:30:00  ERS_D_Ld5.TL319_oQU240wLI_ais8to30.MPAS_FOLISIO_JRA1p5.chrysalis_gnu

PASSED

I have a longer test with TL319_IcoswISC30E3r5_ais4to20.GMPAS-JRA1p5-DIB-TFISMF-MALI that I will report on later.

@matthewhoffman
Copy link
Contributor Author

I ran a 4-year simulation using the new compset: TL319_IcoswISC30E3r5_ais4to20.GMPAS-JRA1p5-DIB-TFISMF-MALI
For the most part things behaved as expected, but in looking at MPAS-Analysis output, I realized a problem with combining TFISMF and DIB - because DIB sets config_remove_ais_ice_runoff = .true., the iceRunoff flux passed from MALI gets zeroed by MPAS-Ocean and not actually applied. I will do some further investigation before determining whether this is easily fixable as part of this PR or the new compset should be removed from the PR and this issue addressed separately.

@matthewhoffman
Reduce frequency and size of MALI hist files
cfd0a1e 
* Changed from daily output to 10-day interval
* Removed mesh fields
* Removed fields that we are unlikely to look at very often
@matthewhoffman
Add MALI buildnml support for a TF-coupling parameters file
11cf96b 
When OCN/GLC coupling is active, MALI requires a separate input file
with parameters for the ice-shelf basal melt parameterization.  These
parameters are specific to each MALI mesh.  This commit adds MALI
buildnml support for this additional input file if TF coupling is active
AND the params file has been set up for a given MALI mesh.  For MALI
meshes that do not have a param file set up, ice-shelf basal melting
will be zero.

Note that in the future, these parameters may also be a function of OCN
mesh and compset.  The needed level of complexity is not yet known, so
this logic will be adjusted to accommodate that when the time comes.
@matthewhoffman matthewhoffman force-pushed the matthewhoffman/mali/gamma0-default branch from 363381f to 11cf96b Compare July 28, 2025 19:32
@matthewhoffman
Copy link
Contributor Author

I rebased and removed the commit (5f1038c) that had added the new G-case compset. That will be addressed in a separate PR. Based on the most recent testing comment I added above, this PR is ready for final review and merge.

@jonbob jonbob added the non-BFB PR makes roundoff changes to answers. label Jul 29, 2025
jonbob added a commit that referenced this pull request Jul 29, 2025
@jonbob
Merge branch 'matthewhoffman/mali/gamma0-default' into next (PR #7529)
caee730 
Cleanup to OCN/GLC TF-coupling

This branch addresses a few details to get production simulations using
TF coupling ready:
1. Adjustments to MALI hist fields to make output volume more manageable
   in multiyear runs
2. Add grid-dependent parameter files for TF-coupling. For TF-coupling
   to be used to generate melt rates using the ISMIP6/Jourdain ice-shelf
   basal melting parameterization in MALI, MALI requires a parameter
   file that includes the gamma0 melt sensitivity parameter, the
   ice-shelf region masks (different than the regional stats mask), and
   an optional ocean temperature bias correction field. Such files have
   been added to the input data repo and added to the MALI
   streams.landice file for the two Antarctic Ice Sheet meshes when
   appropriate conditions are met.

[non-BFB] only for ais configurations with MALI and MPAS-O
@jonbob
Copy link
Contributor

jonbob commented Jul 29, 2025

passes e3sm_landice_developer suite on chrysalis with gnu except for expected DIFF in:

  • ERS_Ld5.TL319_oQU240wLI_ais8to30.MPAS_FOLISIO_JRA1p5.chrysalis_gnu.mpaso-jra_1958

merged to next

@jonbob jonbob merged commit f32ae4f into master Jul 30, 2025
2 checks passed
@jonbob jonbob deleted the matthewhoffman/mali/gamma0-default branch July 30, 2025 18:07
@jonbob
Copy link
Contributor

jonbob commented Jul 30, 2025

merged to master and expected DIFFs blessed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trhille trhille trhille approved these changes

+1 more reviewer

@irenavankova irenavankova irenavankova approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jonbob jonbob

Labels
mpas-albany-landice non-BFB PR makes roundoff changes to answers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewhoffman @jonbob @irenavankova @trhille