-
Notifications
You must be signed in to change notification settings - Fork 434
Add workflow for weekly kokkos develop testing #7643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,6 +41,13 @@ inputs: | |
description: 'Semicolon-separated list of key=value pairs for CMake to pass to test-all-eamxx' | ||
required: false | ||
default: '' | ||
kokkos_develop: | ||
description: 'Whether or not this is a test using Kokkos develop branch' | ||
required: false | ||
default: 'false' | ||
valid_values: | ||
- 'true' | ||
- 'false' | ||
|
||
runs: | ||
using: "composite" | ||
|
@@ -77,6 +84,18 @@ runs: | |
echo " generate : ${{ inputs.generate }}" | ||
echo " submit : ${{ inputs.submit }}" | ||
echo " cmake-configs: ${{ inputs.cmake-configs }}" | ||
echo " kokkos dev : ${{ inputs.kokkos_develop }}" | ||
shell: sh | ||
- name: Checkout Kokkos develop branch | ||
if: ${{ inputs.kokkos_develop == 'true' }} | ||
working-directory: externals/ekat/extern/kokkos | ||
run: | | ||
echo "Check out up-to-date Kokkos develop branch" | ||
if ! git remote | grep -q upstream; then | ||
git remote add upstream https://github.com/kokkos/kokkos.git | ||
fi | ||
git fetch upstream | ||
git checkout upstream/develop | ||
Comment on lines
+89
to
+98
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Before running test-all-eamxx, checkout Kokkos develop. |
||
shell: sh | ||
- name: Run test-all-eamxx | ||
working-directory: components/eamxx | ||
|
@@ -98,6 +117,14 @@ runs: | |
cmd+=" -c $config" | ||
done | ||
|
||
# Add additional id for CDASH submit, and necessary cmake vars if this is a kokkos-develop test | ||
if [ "${{ inputs.kokkos_develop }}" = "true" ]; then | ||
cmd+=" --additional-id kokkos_develop" | ||
cmd+=" -c CMAKE_CXX_STANDARD=20" | ||
cmd+=" -c Kokkos_ENABLE_IMPL_VIEW_LEGACY=ON" | ||
cmd+=" -c Kokkos_ENABLE_DEPRECATED_CODE_4=ON" | ||
fi | ||
Comment on lines
+120
to
+126
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add additional ID and set necessary CMake vars. I need to take a look at the issues with needing |
||
|
||
# Print the full command, then run it | ||
echo "test-all-eamxx call: $cmd" | ||
$cmd | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,8 @@ def __init__(self, cxx_compiler=None, f90_compiler=None, c_compiler=None, | |
local=False, root_dir=None, work_dir=None, | ||
quick_rerun=False,quick_rerun_failed=False, | ||
make_parallel_level=0, ctest_parallel_level=0, | ||
extra_verbose=False, limit_test_regex=None, test_level="at", test_size=None): | ||
extra_verbose=False, limit_test_regex=None, test_level="at", test_size=None, | ||
additional_id=""): | ||
########################################################################### | ||
|
||
# When using scripts-tests, we can't pass "-l" to test-all-eamxx, | ||
|
@@ -61,6 +62,7 @@ def __init__(self, cxx_compiler=None, f90_compiler=None, c_compiler=None, | |
self._test_level = test_level | ||
self._test_size = test_size | ||
self._generate = generate | ||
self._additional_id = additional_id | ||
|
||
if self._quick_rerun_failed: | ||
self._quick_rerun = True | ||
|
@@ -474,7 +476,8 @@ def generate_ctest_config(self, cmake_config, extra_configs, test): | |
result += f"-DBUILD_WORK_DIR={work_dir} " | ||
|
||
build_name_mod = str(test) | ||
result += f"-DBUILD_NAME_MOD={build_name_mod} " | ||
testid = "_" + self._additional_id if self._additional_id != "" else "" | ||
result += f"-DBUILD_NAME_MOD={build_name_mod}{testid} " | ||
Comment on lines
+479
to
+480
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let me know what you think of this, can't decide if I think it's too hacky, but don't have any other good ideas. |
||
|
||
if self._limit_test_regex: | ||
result += f"-DINCLUDE_REGEX={self._limit_test_regex} " | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically,
eamxx-sa-testing.yml
needs to set this variable if this is a Kokkos dev branch test.