EAMxx: Time interpolation for Linoz and Oxidants #7722
+11
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odiazib
added
non-BFB
odiazib
force-pushed
the
eamxx/time_interpolation_linoz_oxid
branch
from
8229212 to
93cc466
Compare
|
@odiazib: Could you please add how this PR will change (i.e., shift in the time/day) the interpolation? I think with this PR, it will be consistent with how EAM interpolates these fields, right? |
|
@odiazib: Do you know why the tests are failing in the compare namelist step (NML fail)? |
…es contained an issue with the time variable. The new files are limited to a single year.
odiazib
force-pushed
the
eamxx/time_interpolation_linoz_oxid
branch
from
a64b1ea to
09acb5d
Compare
I am not sure why, but I rebased this branch against master. Let’s see if the rebasing helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating the time interpolation for LINOZ and oxidants. As part of this PR, the routines developed by @TaufiqHassan will be used. Additionally, the NetCDF files for LINOZ and oxidants are being replaced with updated versions due to issues with the time variable in the previous files.
After this PR, time interpolation will be consistent with the DataInterpolation class and EAM. Note that we are using the routine implemented in PR 7381.
Further details: The current implementation does not account for the number of days in each month; it only checks the month to select a time slice.
The test
mam4_aero_microphys_standalone_baseline_cmpwill fail for the configurationsgcc-openmpandgcc-cuda, except forgcc-openmp/fpe(this test does not compare baselines).The test
cpu-gcc/REP_D_Ln5.ne4pg2_oQU480.F2010-EAMxx-MAM4xxwill also fail the baseline comparison.[NBFB]