Skip to content

Fix missing header in installed ekats and fix EkatConfigFile #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

Fix missing header in installed ekats and fix EkatConfigFile #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b369bc3
Fix missing header in installed ekats
jgfouca Aug 13, 2025
4b3b953
Do not use EKAT_BINARY_DIR as working dir for EkatConfigFile
jgfouca Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmake/EkatUtils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,13 @@ macro (EkatConfigFile CONFIG_FILE_IN CONFIG_FILE_C)
if (EKAT_CONFIGURE_FILE_F90_FILE)
# run sed to change '/*...*/' comments into '!/*...*/'
execute_process(COMMAND sed "s;^/;!/;g"
WORKING_DIRECTORY ${EKAT_BINARY_DIR}
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
INPUT_FILE ${CONFIG_FILE_C}
OUTPUT_FILE ${EKAT_CONFIGURE_FILE_F90_FILE})

# do the same for '//...' comments (turn them into '! ...'
execute_process(COMMAND sed "s;^//;!;g"
WORKING_DIRECTORY ${EKAT_BINARY_DIR}
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
INPUT_FILE ${CONFIG_FILE_C}
OUTPUT_FILE ${EKAT_CONFIGURE_FILE_F90_FILE})
endif()
Expand Down
1 change: 1 addition & 0 deletions src/kokkos/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ set (HEADERS
ekat_kokkos_types.hpp
ekat_math_utils.hpp
ekat_subview_utils.hpp
ekat_kokkos_str_utils.hpp
ekat_team_policy_utils.hpp
ekat_upper_bound.hpp
ekat_view_utils.hpp
Expand Down