Fix EkatConfig.cmake so that the if statements are non-empty #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When installing ekat, I noticed the following lines in EkatConfig.cmake:
This is not valid cmake, as the if command requires at least one arg. The problem stems from the fact that we used
<PKGNAME>_FOUND
in EkatConfig.cmake.in, but these vars are LOCAL to the scope wherefind_package(...)
was called. To overcome this, let's use some helper cache variables, which we set to ON/OFF depending on whether Ekat builds the tpl or not.Testing
I verified that the generated EkatConfig.cmake file is indeed valid. As a TODO item, we may want to create a dummy cmake project (perhaps inside ekat's repo) that links against ekat. and that we can use in our CI to verify that the ekat installation logic works as expected.