WorkspaceManager: Make constant a CPP define to make it easier to link #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm-gpu + nvidia cannot link WSM in its prior form.
|
I tried changing the constant to a |
|
How about a constexpr function? (possibly decorated via KOKKOS_INLINE_FUNCTION if it needs to be device friendly) |
|
Another thought: while at it, we could prob add a check that the factor is >0? Something down the road may crash anyways, but at least we could stop early with a meaningful message... |
|
@bartgol , good points. Done. |
bartgol
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pm-gpu + nvidia cannot link WSM in its prior form.
Testing
Tested a branch @ndkeen gave me. It builds.